]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bonding: fix a potential double-unregister
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 15 Aug 2020 03:05:58 +0000 (20:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 16 Aug 2020 22:13:29 +0000 (15:13 -0700)
commit832707021666411d04795c564a4adea5d6b94f17
treec42a9010e1a5bff0932bb320d6cd7994357e5111
parent81dbf2191f60ccf90f65171d6593c420ee05507f
bonding: fix a potential double-unregister

When we tear down a network namespace, we unregister all
the netdevices within it. So we may queue a slave device
and a bonding device together in the same unregister queue.

If the only slave device is non-ethernet, it would
automatically unregister the bonding device as well. Thus,
we may end up unregistering the bonding device twice.

Workaround this special case by checking reg_state.

Fixes: 9b5e383c11b0 ("net: Introduce unregister_netdevice_many()")
Reported-by: syzbot+af23e7f3e0a7e10c8b67@syzkaller.appspotmail.com
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c