]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing: Fix very unlikely race of registering two stat tracers
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 24 Jan 2020 22:47:49 +0000 (17:47 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 24 Jan 2020 22:54:06 +0000 (17:54 -0500)
commitdfb6cd1e654315168e36d947471bd2a0ccd834ae
treec7537a632b50bd3db4dcd8a54bd8bef8cc9ff8d6
parent659ded30272d67a04b3692f0bfa12263be20d790
tracing: Fix very unlikely race of registering two stat tracers

Looking through old emails in my INBOX, I came across a patch from Luis
Henriques that attempted to fix a race of two stat tracers registering the
same stat trace (extremely unlikely, as this is done in the kernel, and
probably doesn't even exist). The submitted patch wasn't quite right as it
needed to deal with clean up a bit better (if two stat tracers were the
same, it would have the same files).

But to make the code cleaner, all we needed to do is to keep the
all_stat_sessions_mutex held for most of the registering function.

Link: http://lkml.kernel.org/r/1410299375-20068-1-git-send-email-luis.henriques@canonical.com
Fixes: 002bb86d8d42f ("tracing/ftrace: separate events tracing and stats tracing engine")
Reported-by: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_stat.c