]> git.ipfire.org Git - thirdparty/linux.git/commit - lib/scatterlist.c
lib/scatterlist: Hook sg_kmalloc into kmemleak (v2)
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 28 Jul 2010 21:59:02 +0000 (22:59 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 28 Jul 2010 21:59:02 +0000 (22:59 +0100)
commitb94de9bb7519f597a3aed521d5eaeb5b02a7cbc0
tree1c2771372fc23c55dd678080aa6529c98f8de371
parenta2b6bf63cb7a3e34bd2e753a6f2c2776b5c8496f
lib/scatterlist: Hook sg_kmalloc into kmemleak (v2)

kmemleak ignores page_alloc() and so believes the final sub-page
allocation using the plain kmalloc is decoupled and lost. This leads to
lots of false-positives with code that uses scatterlists.

The options seem to be either to tell kmemleak that the kmalloc is not
leaked or to notify kmemleak of the page allocations. The danger of the
first approach is that we may hide a real leak, so choose the latter
approach (of which I am not sure of the downsides).

v2: Added comments on the suggestion of Catalin.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
lib/scatterlist.c