]> git.ipfire.org Git - thirdparty/linux.git/commit
sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE()
authorIngo Molnar <mingo@kernel.org>
Thu, 11 Aug 2022 06:54:52 +0000 (08:54 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 12 Aug 2022 09:25:10 +0000 (11:25 +0200)
commit09348d75a6ce60eec85c86dd0ab7babc4db3caf6
tree6620daab9bd9ccba94eb8dcb1021cb9ae6a2d4ff
parentffcf9c5700e49c0aee42dcba9a12ba21338e8136
sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE()

There's no good reason to crash a user's system with a BUG_ON(),
chances are high that they'll never even see the crash message on
Xorg, and it won't make it into the syslog either.

By using a WARN_ON_ONCE() we at least give the user a chance to report
any bugs triggered here - instead of getting silent hangs.

None of these WARN_ON_ONCE()s are supposed to trigger, ever - so we ignore
cases where a NULL check is done via a BUG_ON() and we let a NULL
pointer through after a WARN_ON_ONCE().

There's one exception: WARN_ON_ONCE() arguments with side-effects,
such as locking - in this case we use the return value of the
WARN_ON_ONCE(), such as in:

 -       BUG_ON(!lock_task_sighand(p, &flags));
 +       if (WARN_ON_ONCE(!lock_task_sighand(p, &flags)))
 +               return;

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/YvSsKcAXISmshtHo@gmail.com
kernel/sched/autogroup.c
kernel/sched/core.c
kernel/sched/cpupri.c
kernel/sched/deadline.c
kernel/sched/fair.c
kernel/sched/rt.c
kernel/sched/sched.h