]> git.ipfire.org Git - thirdparty/linux.git/commit
rtc: meson-vrtc: Use ktime_get_real_ts64() to get the current time
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Mon, 20 Mar 2023 21:21:42 +0000 (22:21 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 21 Mar 2023 20:15:10 +0000 (21:15 +0100)
commit0e6255fa3f649170da6bd1a544680589cfae1131
tree4abf805f9357457213f4686361a13e4877493a7b
parentab0fccc373d505c9a09bf459557768ab3177e0d2
rtc: meson-vrtc: Use ktime_get_real_ts64() to get the current time

The VRTC alarm register can be programmed with an amount of seconds
after which the SoC will be woken up by the VRTC timer again. We are
already converting the alarm time from meson_vrtc_set_alarm() to
"seconds since 1970". This means we also need to use "seconds since
1970" for the current time.

This fixes a problem where setting the alarm to one minute in the future
results in the firmware (which handles wakeup) to output (on the serial
console) that the system will be woken up in billions of seconds.
ktime_get_raw_ts64() returns the time since boot, not since 1970. Switch
to ktime_get_real_ts64() to fix the calculation of the alarm time and to
make the SoC wake up at the specified date/time. Also the firmware
(which manages suspend) now prints either 59 or 60 seconds until wakeup
(depending on how long it takes for the system to enter suspend).

Fixes: 6ef35398e827 ("rtc: Add Amlogic Virtual Wake RTC")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20230320212142.2355062-1-martin.blumenstingl@googlemail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-meson-vrtc.c