]> git.ipfire.org Git - thirdparty/linux.git/commit
objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic blocks
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 27 Feb 2024 07:35:27 +0000 (23:35 -0800)
committerKees Cook <keescook@chromium.org>
Fri, 1 Mar 2024 06:34:42 +0000 (22:34 -0800)
commit10b4c4bce3f5541f54bcc2039720b11d2bc96d79
tree87d1ec639788aaf83ab690eeb4c49986f08a113e
parentc5e6d3d85efa7451590edd94725b4b280e2fd8a3
objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic blocks

If SAVE and RESTORE unwind hints are in different basic blocks, and
objtool sees the RESTORE before the SAVE, it errors out with:

  vmlinux.o: warning: objtool: vmw_port_hb_in+0x242: objtool isn't smart enough to handle this CFI save/restore combo

In such a case, defer following the RESTORE block until the
straight-line path gets followed later.

Fixes: 8faea26e6111 ("objtool: Re-add UNWIND_HINT_{SAVE_RESTORE}")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402240702.zJFNmahW-lkp@intel.com/
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://lore.kernel.org/r/20240227073527.avcm5naavbv3cj5s@treble
Signed-off-by: Kees Cook <keescook@chromium.org>
tools/objtool/check.c