]> git.ipfire.org Git - thirdparty/linux.git/commit
serial: stm32: Return IRQ_NONE in the ISR if no handling happend
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 17 Apr 2024 09:03:27 +0000 (11:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2024 11:26:45 +0000 (13:26 +0200)
commit13c785323b36b845300b256d0e5963c3727667d7
treeddba327a81f987725ab336b1c67f8d689cd24442
parent1aa4ad4eb695bac1b0a7ba542a16d6833c9c8dd8
serial: stm32: Return IRQ_NONE in the ISR if no handling happend

If there is a stuck irq that the handler doesn't address, returning
IRQ_HANDLED unconditionally makes it impossible for the irq core to
detect the problem and disable the irq. So only return IRQ_HANDLED if
an event was handled.

A stuck irq is still problematic, but with this change at least it only
makes the UART nonfunctional instead of occupying the (usually only) CPU
by 100% and so stall the whole machine.

Fixes: 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/5f92603d0dfd8a5b8014b2b10a902d91e0bb881f.1713344161.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/stm32-usart.c