]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/meson: improve encoder probe / initialization error handling
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sun, 18 Feb 2024 17:50:35 +0000 (18:50 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Mon, 19 Feb 2024 08:48:41 +0000 (09:48 +0100)
commit1a9e51bef89af0f0976cf4c83a1e682895695dcf
tree56d9c077c0e6da768754ea9b3865897b70962052
parent239cce651ea617002ff26f068f2568b2baf6421a
drm/meson: improve encoder probe / initialization error handling

Rename meson_encoder_{cvbs,dsi,hdmi}_init() to
meson_encoder_{cvbs,dsi,hdmi}_probe() so it's clear that these functions
are used at probe time during driver initialization. Also switch all
error prints inside those functions to use dev_err_probe() for
consistency.

This makes the code more straight forward to read and makes the error
prints within those functions consistent (by logging all -EPROBE_DEFER
with dev_dbg(), while actual errors are logged with dev_err() and get
the error value printed).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240218175035.1948165-1-martin.blumenstingl@googlemail.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240218175035.1948165-1-martin.blumenstingl@googlemail.com
drivers/gpu/drm/meson/meson_drv.c
drivers/gpu/drm/meson/meson_encoder_cvbs.c
drivers/gpu/drm/meson/meson_encoder_cvbs.h
drivers/gpu/drm/meson/meson_encoder_dsi.c
drivers/gpu/drm/meson/meson_encoder_dsi.h
drivers/gpu/drm/meson/meson_encoder_hdmi.c
drivers/gpu/drm/meson/meson_encoder_hdmi.h