]> git.ipfire.org Git - thirdparty/linux.git/commit
HID: input: fix a4tech horizontal wheel custom usage
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tue, 11 Jun 2019 12:13:20 +0000 (14:13 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 5 Aug 2019 12:37:15 +0000 (14:37 +0200)
commit1c703b53e5bfb5c2205c30f0fb157ce271fd42fb
tree649b3c43763616dba42506642fa5636e88624a1d
parent49869d2ea9eecc105a10724c1abf035151a3c4e2
HID: input: fix a4tech horizontal wheel custom usage

Some a4tech mice use the 'GenericDesktop.00b8' usage to inform whether
the previous wheel report was horizontal or vertical. Before
c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key") this
usage was being mapped to 'Relative.Misc'. After the patch it's simply
ignored (usage->type == 0 & usage->code == 0). Which ultimately makes
hid-a4tech ignore the WHEEL/HWHEEL selection event, as it has no
usage->type.

We shouldn't rely on a mapping for that usage as it's nonstandard and
doesn't really map to an input event. So we bypass the mapping and make
sure the custom event handling properly handles both reports.

Fixes: c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-a4tech.c