]> git.ipfire.org Git - thirdparty/linux.git/commit
misc: hpilo: fix inconsistent device numbers
authorIan Abbott <abbotti@mev.co.uk>
Fri, 19 Jan 2024 13:20:17 +0000 (13:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jan 2024 00:19:32 +0000 (16:19 -0800)
commit1c9a697bc9b2f77bf6b9efef63d49a72580990e9
tree3b68e9558c88997276bc0791e03ff0c4e50e89e0
parent41bccc98fb7931d63d03f326a746ac4d429c1dd3
misc: hpilo: fix inconsistent device numbers

Each iLO device is allocated `max_ccb` minor device numbers (one for
each channel).  When `ilo_probe()` calls `device_create()` in a loop,
the minor device numbers passed to `device_create()` start at 0.  For
consistency with the call to `cdev_add()`, and for consistency with the
calls to `device_destroy()` from `ilo_remove()`, the minor device
numbers passed to `device_create()` should start at the value in the
variable `start`.  Fix it.

This is a logical bug rather than an actual bug, because the number of
supported devices is `MAX_ILO_DEV` which is defined as `1`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20240119132032.106053-2-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/hpilo.c