]> git.ipfire.org Git - thirdparty/linux.git/commit
perf top: Always sample time to satisfy needs of use of ordered queuing
authorJiri Olsa <jolsa@kernel.org>
Mon, 15 Apr 2019 12:53:33 +0000 (14:53 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 16 Apr 2019 15:36:20 +0000 (12:36 -0300)
commit1e6db2ee86e6a4399fc0ae5689e55e0fd1c43caf
tree5c15b074bee40621a4e456d0def5bee9d196eaa5
parentb24131eb77429f7ac52d5ab5a4313fccff64c411
perf top: Always sample time to satisfy needs of use of ordered queuing

Bastian reported broken 'perf top -p PID' command, it won't display any
data.

The problem is that for -p option we monitor single thread, so we don't
enable time in samples, because it's not needed.

However since commit 16c66bc167cc we use ordered queues to stash data
plus later commits added logic for dropping samples in case there's big
load and we don't keep up. All this needs timestamp for sample. Enabling
it unconditionally for perf top.

Reported-by: Bastian Beischer <bastian.beischer@rwth-aachen.de>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: bastian beischer <bastian.beischer@rwth-aachen.de>
Fixes: 16c66bc167cc ("perf top: Add processing thread")
Link: http://lkml.kernel.org/r/20190415125333.27160-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c