]> git.ipfire.org Git - thirdparty/linux.git/commit
selftests/tcp_ao: Make RST tests less flaky
authorDmitry Safonov <0x7f454c46@gmail.com>
Sat, 13 Apr 2024 01:42:52 +0000 (02:42 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 16 Apr 2024 11:35:05 +0000 (13:35 +0200)
commit4225dfa4535f219b03ae14147d9c6e7e82ec8df4
treee3b786440767cd7e5d1c01628b1f61b67fbd12b8
parent75ce9506ee3dc66648a7d74ab3b0acfa364d6d43
selftests/tcp_ao: Make RST tests less flaky

Currently, "active reset" cases are flaky, because select() is called
for 3 sockets, while only 2 are expected to receive RST.
The idea of the third socket was to get into request_sock_queue,
but the test mistakenly attempted to connect() after the listener
socket was shut down.

Repair this test, it's important to check the different kernel
code-paths for signing RST TCP-AO segments.

Fixes: c6df7b2361d7 ("selftests/net: Add TCP-AO RST test")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/tcp_ao/rst.c