]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/xe/xe2: fix 64-bit division in pte_update_size
authorArnd Bergmann <arnd@arndb.de>
Mon, 26 Feb 2024 12:46:38 +0000 (13:46 +0100)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 4 Mar 2024 14:41:14 +0000 (08:41 -0600)
commit45cfade303335c486300b81e62caefffa843f585
treeb4ed31247d4ce3a5df439c7dfa0379745b8af6fb
parentd1d95985ab66b6605286bc00d757054ce22f7d1d
drm/xe/xe2: fix 64-bit division in pte_update_size

This function does not build on 32-bit targets when the compiler
fails to reduce DIV_ROUND_UP() into a shift:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by xe_migrate.c
>>>               drivers/gpu/drm/xe/xe_migrate.o:(pte_update_size) in archive vmlinux.a

There are two instances in this function. Change the first to
use an open-coded shift with the same behavior, and the second
one to a 32-bit calculation, which is sufficient here as the size
is never more than 2^32 pages (16TB).

Fixes: 237412e45390 ("drm/xe: Enable 32bits build")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240226124736.1272949-3-arnd@kernel.org
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit 1408784b599927d2f361bac6dc5170d2ee275f17)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_migrate.c