]> git.ipfire.org Git - thirdparty/linux.git/commit
ASoC: cs35l33: Fix GPIO name and drop legacy include
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 1 Dec 2023 13:20:31 +0000 (14:20 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 1 Dec 2023 16:59:17 +0000 (16:59 +0000)
commit50678d339d670a92658e5538ebee30447c88ccb3
treee28b0139532478f09ddf38311659c8c1dbe5d00c
parentf8dd1f89bd5ecbfcc547ee5b222a4b9ddb0a0160
ASoC: cs35l33: Fix GPIO name and drop legacy include

This driver includes the legacy GPIO APIs <linux/gpio.h> and
<linux/of_gpio.h> but does not use any symbols from any of
them.

Drop the includes.

Further the driver is requesting "reset-gpios" rather than
just "reset" from the GPIO framework. This is wrong because
the gpiolib core will add "-gpios" before processing the
request from e.g. device tree. Drop the suffix.

The last problem means that the optional RESET GPIO has
never been properly retrieved and used even if it existed,
but nobody noticed.

Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20231201-descriptors-sound-cirrus-v2-2-ee9f9d4655eb@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l33.c