]> git.ipfire.org Git - thirdparty/linux.git/commit
mips: lib: uncached: fix non-standard usage of variable 'sp'
authorAnders Roxell <anders.roxell@linaro.org>
Fri, 11 Dec 2020 10:24:37 +0000 (11:24 +0100)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 14 Dec 2020 15:03:11 +0000 (16:03 +0100)
commit5b058973d3205578aa6c9a71392e072a11ca44ef
tree9e63972f9db390b059ce1c0af5a11ebbd0382177
parent991838f90e9315468cd1d1daed29d27faae77a9b
mips: lib: uncached: fix non-standard usage of variable 'sp'

When building mips tinyconfig with clang the following warning show up:

arch/mips/lib/uncached.c:45:6: warning: variable 'sp' is uninitialized when used here [-Wuninitialized]
        if (sp >= (long)CKSEG0 && sp < (long)CKSEG2)
            ^~
arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to silence this warning
        register long sp __asm__("$sp");
                        ^
                         = 0
1 warning generated.

Rework to make an explicit inline move, instead of the non-standard use
of specifying registers for local variables. This is what's written
from the gcc-10 manual [1] about specifying registers for local
variables:

"6.47.5.2 Specifying Registers for Local Variables
.................................................
[...]

"The only supported use for this feature is to specify registers for
input and output operands when calling Extended 'asm' (*note Extended
Asm::).  [...]".

[1] https://docs.w3cub.com/gcc~10/local-register-variables
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/lib/uncached.c