]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: compress: prevent potential divide by zero bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Dec 2018 09:06:58 +0000 (12:06 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 3 Jan 2019 16:32:57 +0000 (16:32 +0000)
commit678e2b44c8e3fec3afc7202f1996a4500a50be93
treea189206cb58a46b267a11e2bc7b54d64721e6952
parenta41d9dbf5dac5b6a1283ee8001f22807d18352ea
ALSA: compress: prevent potential divide by zero bugs

The problem is seen in the q6asm_dai_compr_set_params() function:

ret = q6asm_map_memory_regions(dir, prtd->audio_client, prtd->phys,
       (prtd->pcm_size / prtd->periods),
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       prtd->periods);

In this code prtd->pcm_size is the buffer_size and prtd->periods comes
from params->buffer.fragments.  If we allow the number of fragments to
be zero then it results in a divide by zero bug.  One possible fix would
be to use prtd->pcm_count directly instead of using the division to
re-calculate it.  But I decided that it doesn't really make sense to
allow zero fragments.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/core/compress_offload.c