]> git.ipfire.org Git - thirdparty/linux.git/commit
netfilter: nf_tables: skip set commit for deleted/destroyed sets
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 19 Dec 2023 18:44:49 +0000 (19:44 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 20 Dec 2023 12:48:00 +0000 (13:48 +0100)
commit7315dc1e122c85ffdfc8defffbb8f8b616c2eb1a
tree64979168ce16f35f7f7bd6e3d24bd9bfc6e9cc9a
parent0ae8e4cca78781401b17721bfb72718fdf7b4912
netfilter: nf_tables: skip set commit for deleted/destroyed sets

NFT_MSG_DELSET deactivates all elements in the set, skip
set->ops->commit() to avoid the unnecessary clone (for the pipapo case)
as well as the sync GC cycle, which could deactivate again expired
elements in such set.

Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane")
Reported-by: Kevin Rich <kevinrich1337@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c