]> git.ipfire.org Git - thirdparty/linux.git/commit
wireguard: socket: remove bogus __be32 annotation
authorJann Horn <jannh@google.com>
Mon, 22 Feb 2021 16:25:44 +0000 (17:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Feb 2021 23:53:49 +0000 (15:53 -0800)
commit7f57bd8dc22de35ddd895294aa554003e4f19a72
treef0385fd254589f4706fc56333177fcf9e1903829
parent30ac4e2f54ec067b7b9ca0db27e75681581378d6
wireguard: socket: remove bogus __be32 annotation

The endpoint->src_if4 has nothing to do with fixed-endian numbers; remove
the bogus annotation.

This was introduced in
https://git.zx2c4.com/wireguard-monolithic-historical/commit?id=14e7d0a499a676ec55176c0de2f9fcbd34074a82
in the historical WireGuard repo because the old code used to
zero-initialize multiple members as follows:

    endpoint->src4.s_addr = endpoint->src_if4 = fl.saddr = 0;

Because fl.saddr is fixed-endian and an assignment returns a value with the
type of its left operand, this meant that sparse detected an assignment
between values of different endianness.

Since then, this assignment was already split up into separate statements;
just the cast survived.

Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireguard/socket.c