]> git.ipfire.org Git - thirdparty/linux.git/commit
mm/page_alloc.c: avoid potential NULL pointer dereference
authorAndrey Ryabinin <aryabinin@virtuozzo.com>
Fri, 26 Apr 2019 05:23:58 +0000 (22:23 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 26 Apr 2019 16:18:05 +0000 (09:18 -0700)
commit8139ad043d632c0e9e12d760068a7a8e91659aa1
tree0f1168febb3f2741513726bd7832a419147cde35
parentee8ab0eeb49bd3982090c8f14dc9cc65bcd13c5c
mm/page_alloc.c: avoid potential NULL pointer dereference

ac.preferred_zoneref->zone passed to alloc_flags_nofragment() can be NULL.
'zone' pointer unconditionally derefernced in alloc_flags_nofragment().
Bail out on NULL zone to avoid potential crash.  Currently we don't see
any crashes only because alloc_flags_nofragment() has another bug which
allows compiler to optimize away all accesses to 'zone'.

Link: http://lkml.kernel.org/r/20190423120806.3503-1-aryabinin@virtuozzo.com
Fixes: 6bb154504f8b ("mm, page_alloc: spread allocations across zones before introducing fragmentation")
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/page_alloc.c