]> git.ipfire.org Git - thirdparty/linux.git/commit
staging: comedi: amplc_pc236_common: Use 16-bit 0 for interrupt data
authorIan Abbott <abbotti@mev.co.uk>
Tue, 23 Feb 2021 14:30:51 +0000 (14:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:23:29 +0000 (09:23 +0100)
commit8536749d4952649ada4a88396079e6ec69c1fc9f
tree88d862bb47f7661593981ead9a27457c39f583d1
parent148e34fd33d53740642db523724226de14ee5281
staging: comedi: amplc_pc236_common: Use 16-bit 0 for interrupt data

The Amplicon PC36AT/PCI236 common driver has an "interrupt" subdevice
that supports Comedi asynchronous commands, placing a value in the
Comedi buffer for each interrupt.  The subdevice uses Comedi's 16-bit
sample format but the interrupt handler is calling
`comedi_buf_write_samples()` with the address of a 32-bit integer
`&s->state`.  On bigendian machines, this will copy 2 bytes from the
wrong end of the 32-bit integer.  This isn't really a problem since
`s->state` will always be 0 for this subdevice, but clean it up by using
a 16-bit variable initialized to 0 to pass the value.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20210223143055.257402-11-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/amplc_pc236_common.c