]> git.ipfire.org Git - thirdparty/linux.git/commit
qtnfmac: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 7 Jun 2019 19:17:45 +0000 (14:17 -0500)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 25 Jun 2019 05:01:32 +0000 (08:01 +0300)
commit9a1ace64ca3b713e1029fed83dc22d8740b20aba
tree77c00aecdbf8026b39b61f3609973bf409f86872
parent23377c200b2eb48a60d0f228b2a2e75ed6ee6060
qtnfmac: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct ieee80211_regdomain {
...
        struct ieee80211_reg_rule reg_rules[];
};

instance = kzalloc(sizeof(*mac->rd) +
                          sizeof(struct ieee80211_reg_rule) *
                          count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, reg_rules, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/quantenna/qtnfmac/commands.c