]> git.ipfire.org Git - thirdparty/linux.git/commit
x86/entry: Move thunk restore code into thunk functions
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 30 May 2023 23:07:41 +0000 (16:07 -0700)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Wed, 7 Jun 2023 16:54:45 +0000 (09:54 -0700)
commitac27ecf68a1ada240bb71531dc2d30cde04ad70a
tree902a33c67cd06f16126d85cf01c40f418ee94d82
parent020126239b8f376ed2f0bef9dc07d0b280a0b7f5
x86/entry: Move thunk restore code into thunk functions

There's no need for both thunk functions to jump to the same shared
thunk restore code which lives outside the thunk function boundaries.
It disrupts i-cache locality and confuses objtool.  Keep it simple by
keeping each thunk's restore code self-contained within the function.

Fixes a bunch of false positive "missing __noreturn" warnings like:

  vmlinux.o: warning: objtool: do_arch_prctl_common+0xf4: preempt_schedule_thunk() is missing a __noreturn annotation

Fixes: fedb724c3db5 ("objtool: Detect missing __noreturn annotations")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305281037.3PaI3tW4-lkp@intel.com/
Link: https://lore.kernel.org/r/46aa8aeb716f302e22e1673ae15ee6fe050b41f4.1685488050.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/x86/entry/thunk_64.S