]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv4: Return error for RTA_VIA attribute
authorDavid Ahern <dsahern@gmail.com>
Tue, 26 Feb 2019 17:00:02 +0000 (09:00 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Feb 2019 21:23:17 +0000 (13:23 -0800)
commitb6e9e5df4ecf100f6a10ab2ade8e46d47a4b9779
tree8e7408d68e9a7d2b48a800c07864ba6e299a7ac1
parent3da1ed7ac398f34fff1694017a07054d69c5f5c5
ipv4: Return error for RTA_VIA attribute

IPv4 currently does not support nexthops outside of the AF_INET family.
Specifically, it does not handle RTA_VIA attribute. If it is passed
in a route add request, the actual route added only uses the device
which is clearly not what the user intended:

  $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0
  $ ip ro ls
  ...
  172.16.1.0/24 dev eth0

Catch this and fail the route add:
  $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0
  Error: IPv4 does not support RTA_VIA attribute.

Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_frontend.c