]> git.ipfire.org Git - thirdparty/linux.git/commit
irqchip/qcom: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 4 Jun 2019 23:16:16 +0000 (18:16 -0500)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 11 Jun 2019 11:45:30 +0000 (12:45 +0100)
commitb744c3bcff5a18ac1f355224eec1c453aab066a2
treed764655e690ff91e9923e43437f1c4c8099e5c6e
parente85c9c90b4316131c94e2297e08ea337586c0471
irqchip/qcom: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = devm_kzalloc(dev, size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

Notice that, in this case, variable alloc_sz is not necessary, hence it
is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/qcom-irq-combiner.c