]> git.ipfire.org Git - thirdparty/linux.git/commit
hv_netvsc: fix race of netvsc and VF register_netdevice
authorHaiyang Zhang <haiyangz@microsoft.com>
Sun, 19 Nov 2023 16:23:41 +0000 (08:23 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 Nov 2023 12:15:02 +0000 (13:15 +0100)
commitd30fb712e52964f2cf9a9c14cf67078394044837
tree378fe07bc1fd2484fdbf85f173f555fa2c10cd8a
parentc0e2926266af3b5acf28df0a8fc6e4d90effe0bb
hv_netvsc: fix race of netvsc and VF register_netdevice

The rtnl lock also needs to be held before rndis_filter_device_add()
which advertises nvsp_2_vsc_capability / sriov bit, and triggers
VF NIC offering and registering. If VF NIC finished register_netdev()
earlier it may cause name based config failure.

To fix this issue, move the call to rtnl_lock() before
rndis_filter_device_add(), so VF will be registered later than netvsc
/ synthetic NIC, and gets a name numbered (ethX) after netvsc.

Cc: stable@vger.kernel.org
Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/hyperv/netvsc_drv.c