]> git.ipfire.org Git - thirdparty/linux.git/commit
NFSv4.1: work around -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Thu, 10 Nov 2016 16:44:45 +0000 (17:44 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 11 Nov 2016 16:45:08 +0000 (08:45 -0800)
commite84efa32b9d2763fb92e73c8942100d8f55ad4ed
tree2a401d9abe634b6931e2903ad694a9f20131adde
parenta76bcf557ef408b368cf26f52a60865bfc27b632
NFSv4.1: work around -Wmaybe-uninitialized warning

A bugfix introduced a harmless gcc warning in nfs4_slot_seqid_in_use if
we enable -Wmaybe-uninitialized again:

  fs/nfs/nfs4session.c:203:54: error: 'cur_seq' may be used uninitialized in this function [-Werror=maybe-uninitialized]

gcc is not smart enough to conclude that the IS_ERR/PTR_ERR pair results
in a nonzero return value here.  Using PTR_ERR_OR_ZERO() instead makes
this clear to the compiler.

Fixes: e09c978aae5b ("NFSv4.1: Fix Oopsable condition in server callback races")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfs/nfs4session.c