]> git.ipfire.org Git - thirdparty/linux.git/commit
bnxt_en: Improve RX doorbell sequence.
authorMichael Chan <michael.chan@broadcom.com>
Sat, 17 Aug 2019 21:04:48 +0000 (17:04 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Aug 2019 20:05:00 +0000 (13:05 -0700)
commite8f267b063208372f7a329c6d5288d58944d873c
tree847a33cc674c63a1a6b2ad01fc84404b421ea448
parenta46ecb116fb7f722fa8cb2da01959c36e4e10c41
bnxt_en: Improve RX doorbell sequence.

When both RX buffers and RX aggregation buffers have to be
replenished at the end of NAPI, post the RX aggregation buffers first
before RX buffers.  Otherwise, we may run into a situation where
there are only RX buffers without RX aggregation buffers for a split
second.  This will cause the hardware to abort the RX packet and
report buffer errors, which will cause unnecessary cleanup by the
driver.

Ringing the Aggregation ring doorbell first before the RX ring doorbell
will prevent some of these buffer errors.  Use the same sequence during
ring initialization as well.

Fixes: 697197e5a173 ("bnxt_en: Re-structure doorbells.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c