]> git.ipfire.org Git - thirdparty/linux.git/commit
i2c: bcm2835: Clear current buffer pointers and counts after a transfer
authorPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Thu, 27 Dec 2018 15:42:25 +0000 (16:42 +0100)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 15 Feb 2019 08:45:05 +0000 (09:45 +0100)
commitf275a4659484716259cc46268d9043424e51cf0f
tree7b3b2a2d2cbd1d675fdea077ad8a9b0bfc86ff50
parentd358def706880defa4c9e87381c5bf086a97d5f9
i2c: bcm2835: Clear current buffer pointers and counts after a transfer

The driver's interrupt handler checks whether a message is currently
being handled with the curr_msg pointer. When it is NULL, the interrupt
is considered to be unexpected. Similarly, the i2c_start_transfer
routine checks for the remaining number of messages to handle in
num_msgs.

However, these values are never cleared and always keep the message and
number relevant to the latest transfer (which might be done already and
the underlying message memory might have been freed).

When an unexpected interrupt hits with the DONE bit set, the isr will
then try to access the flags field of the curr_msg structure, leading
to a fatal page fault.

The msg_buf and msg_buf_remaining fields are also never cleared at the
end of the transfer, which can lead to similar pitfalls.

Fix these issues by introducing a cleanup function and always calling
it after a transfer is finished.

Fixes: e2474541032d ("i2c: bcm2835: Fix hang for writing messages larger than 16 bytes")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-bcm2835.c