]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv6: explicitly initialize udp6_addr in udp_sock_create6()
authorCong Wang <xiyou.wangcong@gmail.com>
Wed, 19 Dec 2018 05:17:44 +0000 (21:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Dec 2018 20:09:00 +0000 (12:09 -0800)
commitfb24274546310872eeeaf3d1d53799d8414aa0f2
tree1cac7553dc1b42090952e2ea288813b413e6e3eb
parent84404d5fd5858588bbf694b0300dbc6310d02737
ipv6: explicitly initialize udp6_addr in udp_sock_create6()

syzbot reported the use of uninitialized udp6_addr::sin6_scope_id.
We can just set ::sin6_scope_id to zero, as tunnels are unlikely
to use an IPv6 address that needs a scope id and there is no
interface to bind in this context.

For net-next, it looks different as we have cfg->bind_ifindex there
so we can probably call ipv6_iface_scope_id().

Same for ::sin6_flowinfo, tunnels don't use it.

Fixes: 8024e02879dd ("udp: Add udp_sock_create for UDP tunnels to open listener socket")
Reported-by: syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_udp_tunnel.c