]> git.ipfire.org Git - thirdparty/lldpd.git/commit
interfaces: remove specific handling for bonds except with --enable-oldies
authorVincent Bernat <vincent@bernat.ch>
Wed, 28 Nov 2018 13:56:47 +0000 (14:56 +0100)
committerVincent Bernat <vincent@bernat.ch>
Fri, 30 Nov 2018 10:16:51 +0000 (11:16 +0100)
commit2f4ff3072b954752ad53254a0c624ac5a46e2f89
tree84c3372d0b75036c781576443ecd985dae66a58b
parentf2e7a911cb264e52ef9f5a56357553eaedfbefd1
interfaces: remove specific handling for bonds except with --enable-oldies

Starting from Linux 4.19, LLDP packets are transmitted back to the
bond devices and it seems the original interface is lost in the
process. Therefore, packets are duplicated to both members. Upstream
commit is:

    commit 6a9e461f6fe4434e6172304b69774daff9a3ac4c
    Author: Mahesh Bandewar <maheshb@google.com>
    Date:   Mon Sep 24 14:39:42 2018 -0700

    bonding: pass link-local packets to bonding master also.

    Commit b89f04c61efe ("bonding: deliver link-local packets with
    skb->dev set to link that packets arrived on") changed the behavior
    of how link-local-multicast packets are processed. The change in
    the behavior broke some legacy use cases where these packets are
    expected to arrive on bonding master device also.

    This patch passes the packet to the stack with the link it arrived
    on as well as passes to the bonding-master device to preserve the
    legacy use case.

Fixes: b89f04c61efe ("bonding: deliver link-local packets with skb->dev set to link that packets arrived on")
Reported-by: Michal Soltys <soltys@ziu.info>
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The code to handle bond devices is not needed since Linux 2.6.27.
Therefore, move it to the `--enable-oldies` option.

Fix #306.
NEWS
src/daemon/interfaces-linux.c