From: Vincent Bernat Date: Mon, 26 Dec 2016 09:55:52 +0000 (+0100) Subject: Revert "tests: mark tests spawning a new port as flaky" X-Git-Tag: 0.9.6~12 X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Flldpd.git;a=commitdiff_plain;h=efae5c833ecb89f41a37c156317d5faf999e1b61 Revert "tests: mark tests spawning a new port as flaky" This reverts commit 0efde559064fc3b842d06b56bafa1c457b1a8fb4. This isn't compatible with xdist... --- diff --git a/tests/integration/requirements.txt b/tests/integration/requirements.txt index 5d5086e0..9528dae7 100644 --- a/tests/integration/requirements.txt +++ b/tests/integration/requirements.txt @@ -1,6 +1,5 @@ apipkg==1.4 execnet==1.4.1 -flaky==3.3.0 py==1.4.31 pyroute2==0.3.16 pytest==2.9.0 diff --git a/tests/integration/test_interfaces.py b/tests/integration/test_interfaces.py index e2766a78..571495e0 100644 --- a/tests/integration/test_interfaces.py +++ b/tests/integration/test_interfaces.py @@ -1,7 +1,6 @@ import pytest import pyroute2 import time -from flaky import flaky def test_simple_bridge(lldpd1, lldpd, lldpcli, namespaces, links): @@ -205,12 +204,11 @@ def test_down_then_up_with_vlan(lldpd1, lldpd, lldpcli, namespaces, links): assert out['lldp.eth0.vlan.vlan-id'] == ['300', '400'] -@flaky def test_new_interface(lldpd1, lldpd, lldpcli, namespaces, links): with namespaces(2): lldpd() links(namespaces(1), namespaces(2)) - time.sleep(8) + time.sleep(10) with namespaces(1): out = lldpcli("-f", "keyvalue", "show", "neighbors", "details") assert out['lldp.eth0.port.descr'] == 'eth1' diff --git a/tests/integration/test_lldpcli.py b/tests/integration/test_lldpcli.py index 39f289d5..2c7fe1e6 100644 --- a/tests/integration/test_lldpcli.py +++ b/tests/integration/test_lldpcli.py @@ -4,7 +4,6 @@ import re import platform import json import xml.etree.ElementTree as ET -from flaky import flaky @pytest.fixture(scope='session') @@ -190,7 +189,6 @@ def test_configure_one_port(lldpd1, lldpd, lldpcli, namespaces, links): @pytest.mark.skipif('Dot3' not in pytest.config.lldpd.features, reason="Dot3 not supported") -@flaky def test_new_port_take_default(lldpd1, lldpd, lldpcli, namespaces, links): with namespaces(2): lldpd() @@ -205,7 +203,7 @@ def test_new_port_take_default(lldpd1, lldpd, lldpcli, namespaces, links): assert out['lldp.eth0.port.descr'] == 'eth1' assert out['lldp.eth0.port.power.device-type'] == 'PSE' links(namespaces(1), namespaces(2)) - time.sleep(8) + time.sleep(10) with namespaces(1): out = lldpcli("-f", "keyvalue", "show", "neighbors", "details") assert out['lldp.eth2.port.descr'] == 'eth3'