]> git.ipfire.org Git - thirdparty/lldpd.git/log
thirdparty/lldpd.git
14 years agoUse "void" instead of empty parameter list for function prototypes.
Vincent Bernat [Thu, 24 Sep 2009 08:27:15 +0000 (10:27 +0200)] 
Use "void" instead of empty parameter list for function prototypes.

Using empty parameter list means that we don't know what are the
parameters of a function, while using "void" means that there is no
parameter for this function. Some compilers are ticky about this. See
C99 6.11.6 and 6.7.5.3 ยง14.

This also allows to fix a little bug: priv_ctl_create was called with
a parameter.

14 years agoUse libtool convenience libraries for common files for lldpd and lldpctl.
Vincent Bernat [Thu, 24 Sep 2009 08:13:27 +0000 (10:13 +0200)] 
Use libtool convenience libraries for common files for lldpd and lldpctl.

Instead of directly linking common files, we use another libtool
convenience library (libcommon.la). We also separate server part of
ctl.c into a separate file to avoid -DCLIENT_ONLY flag which was
causing recompilation of most files.

We also move compatibility objects (like strcpy() function) into
libcommon.la.

14 years agoReplace index() by strchr()
Vincent Bernat [Thu, 9 Jul 2009 19:56:17 +0000 (21:56 +0200)] 
Replace index() by strchr()

strchr() is POSIX while index() is deprecated.

14 years agoWhen SYSFS_BRIDGE_* stuff does not exist, just use old /proc.
Vincent Bernat [Thu, 9 Jul 2009 19:32:50 +0000 (21:32 +0200)] 
When SYSFS_BRIDGE_* stuff does not exist, just use old /proc.

14 years agoCompatibility with gcc 2.95.x: add spaces around __VA__ARGS__
Vincent Bernat [Thu, 9 Jul 2009 19:30:14 +0000 (21:30 +0200)] 
Compatibility with gcc 2.95.x: add spaces around __VA__ARGS__

14 years agoMore ethtool compatibility
Vincent Bernat [Thu, 9 Jul 2009 18:37:26 +0000 (20:37 +0200)] 
More ethtool compatibility

14 years agoCompilation fix for ancient gcc.
Vincent Bernat [Thu, 9 Jul 2009 18:10:43 +0000 (20:10 +0200)] 
Compilation fix for ancient gcc.

gcc 2.96 does not like "char frame[]" declaration and complains with
"array size missing in frame'". We circumvent this limitation by using
a one byte array instead of an undefined one.

14 years agoDo not include <ifaddrs.h> since we want to replace it.
Vincent Bernat [Thu, 9 Jul 2009 18:14:27 +0000 (20:14 +0200)] 
Do not include <ifaddrs.h> since we want to replace it.

14 years agoProvide another getifaddrs implementation, stolen from USAGI project
Vincent Bernat [Thu, 9 Jul 2009 16:05:02 +0000 (18:05 +0200)] 
Provide another getifaddrs implementation, stolen from USAGI project

14 years agoAdd getifaddrs() replacement for system without it.
Vincent Bernat [Wed, 8 Jul 2009 22:10:11 +0000 (00:10 +0200)] 
Add getifaddrs() replacement for system without it.

14 years agoRemove *.pcap file on clean.
Vincent Bernat [Tue, 7 Jul 2009 13:20:07 +0000 (15:20 +0200)] 
Remove *.pcap file on clean.

14 years agoAdd unit tests for EDP
Vincent Bernat [Tue, 7 Jul 2009 13:09:55 +0000 (15:09 +0200)] 
Add unit tests for EDP

14 years agoAdd SONMP unit tests.
Vincent Bernat [Tue, 7 Jul 2009 12:08:06 +0000 (14:08 +0200)] 
Add SONMP unit tests.

14 years agoAdd CDP unit tests.
Vincent Bernat [Tue, 7 Jul 2009 11:39:52 +0000 (13:39 +0200)] 
Add CDP unit tests.

14 years agoMove pcap stuff into a separate file to allow sharing with future tests.
Vincent Bernat [Tue, 7 Jul 2009 08:17:33 +0000 (10:17 +0200)] 
Move pcap stuff into a separate file to allow sharing with future tests.

14 years agoDisable some tests when some features (dot1, dot3, lldpmed) are not
Vincent Bernat [Tue, 7 Jul 2009 07:57:01 +0000 (09:57 +0200)] 
Disable some tests when some features (dot1, dot3, lldpmed) are not
enabled.

14 years agofail_* macros do not break execution flow.
Vincent Bernat [Tue, 7 Jul 2009 07:01:45 +0000 (09:01 +0200)] 
fail_* macros do not break execution flow.

Unlike what happen with unit tests framework in other languages,
fail_* macro does not jump to next test. Therefore, we have to break
flow ourselves.

14 years agoAdd LLDP receive tests
Vincent Bernat [Mon, 6 Jul 2009 13:35:58 +0000 (15:35 +0200)] 
Add LLDP receive tests

14 years agoAdd LLDP send tests.
Vincent Bernat [Mon, 6 Jul 2009 09:42:31 +0000 (11:42 +0200)] 
Add LLDP send tests.

14 years agoAdd unit tests for lists packing/unpacking.
Vincent Bernat [Sun, 5 Jul 2009 18:02:17 +0000 (20:02 +0200)] 
Add unit tests for lists packing/unpacking.

14 years agoUnit tests for packing/unpacking.
Vincent Bernat [Sun, 5 Jul 2009 17:30:56 +0000 (19:30 +0200)] 
Unit tests for packing/unpacking.

We build a static library liblldpd.la to ease linking to tests.
liblldpd.la is equal to lldpd except:
 - no main (but lldpd_main instead)
 - no link to netsnmp (because libtool try to link many many more
   things)

14 years agoUpdate signature of transport string function for SNMP.
Vincent Bernat [Tue, 7 Jul 2009 13:23:07 +0000 (15:23 +0200)] 
Update signature of transport string function for SNMP.

14 years agoFix bug in CDP packet generation: CDP version was always 1.
Vincent Bernat [Tue, 7 Jul 2009 09:42:35 +0000 (11:42 +0200)] 
Fix bug in CDP packet generation: CDP version was always 1.

"(a && b) || c" gives 0 or 1, not b or c. Replace with a?b:c.

14 years agoFix compilation issues when DOT1 or DOT3 are not enabled.
Vincent Bernat [Tue, 7 Jul 2009 07:38:53 +0000 (09:38 +0200)] 
Fix compilation issues when DOT1 or DOT3 are not enabled.

14 years agoFix comment of iface_port_name_desc()
Vincent Bernat [Wed, 10 Jun 2009 13:39:49 +0000 (15:39 +0200)] 
Fix comment of iface_port_name_desc()

14 years agoUse ifAlias from newer Linux kernels if available.
Vincent Bernat [Wed, 10 Jun 2009 13:22:29 +0000 (15:22 +0200)] 
Use ifAlias from newer Linux kernels if available.

From 2.6.28, Linux allows to attach a description to an interface. We
grab this description from /sys/class/net/$IFACE/ifalias if it exists
and is not empty and use it as port description. In this case,
interface name is used as port ID.

 PortID:    veth0 (ifName)
 PortDescr: Test interface

This closes ticket #10.

14 years agoSet h_ifindex correctly.
Vincent Bernat [Tue, 9 Jun 2009 05:42:32 +0000 (07:42 +0200)] 
Set h_ifindex correctly.

We also use this index as a way to define an interface. The following
comment has been added to lldpd.h:

An interface is uniquely identified by h_ifindex, h_ifname and h_ops.
This means if an interface becomes enslaved, it will be considered as
a new interface. The same applies for renaming and we include the
index in case of renaming to an existing interface.

14 years agoAdd a callback mechanism to watch for incoming data on sockets.
Vincent Bernat [Sun, 7 Jun 2009 12:17:45 +0000 (14:17 +0200)] 
Add a callback mechanism to watch for incoming data on sockets.

This callback mechanism is used to handle socket control. It could
also be used when we will need to monitor sockets outside of a port
context.

14 years agoAdd a note about EDP in changelog.
Vincent Bernat [Sat, 6 Jun 2009 21:06:38 +0000 (23:06 +0200)] 
Add a note about EDP in changelog.

14 years agoUpdate changelog.
Vincent Bernat [Sat, 6 Jun 2009 21:04:35 +0000 (23:04 +0200)] 
Update changelog.

14 years agoMake "listen on vlan" feature optional at compile-time.
Vincent Bernat [Thu, 4 Jun 2009 21:26:25 +0000 (23:26 +0200)] 
Make "listen on vlan" feature optional at compile-time.

The code to handle this feature is a bit kludgy and it seems safer to
compile out this feature by default.

14 years agoThere are duplicate in the list of address we give to handler
Vincent Bernat [Thu, 4 Jun 2009 21:16:36 +0000 (23:16 +0200)] 
There are duplicate in the list of address we give to handler
functions. We need to acknowledge this correctly.

For bonds and regular interfaces, just check that h_flags is 0 before
trying to get information one more time.

For VLAN, check if the VLAN is already present in the list.

14 years agoAdd back "listen on VLAN" feature.
Vincent Bernat [Thu, 4 Jun 2009 21:12:40 +0000 (23:12 +0200)] 
Add back "listen on VLAN" feature.

14 years agoOne VLAN can be associated to multiple interfaces through bridge or
Vincent Bernat [Thu, 4 Jun 2009 19:44:40 +0000 (21:44 +0200)] 
One VLAN can be associated to multiple interfaces through bridge or
bond. Handle those cases appropriately.

14 years agoAdd back support for bonding using the new architecture.
Vincent Bernat [Wed, 3 Jun 2009 19:35:31 +0000 (21:35 +0200)] 
Add back support for bonding using the new architecture.

14 years agoDon't free statically allocated port.
Vincent Bernat [Tue, 2 Jun 2009 08:57:15 +0000 (10:57 +0200)] 
Don't free statically allocated port.

14 years agoChange the way interface information are collected.
Vincent Bernat [Tue, 2 Jun 2009 07:56:25 +0000 (09:56 +0200)] 
Change the way interface information are collected.

Move interface related stuff into interfaces.c.
A set of handlers are called sequentially to handle interfaces.

14 years agoMove chassis update to a function.
Vincent Bernat [Sun, 31 May 2009 08:35:11 +0000 (10:35 +0200)] 
Move chassis update to a function.

Later, the function could be replaced with something less hackish if
needed.

14 years agoFix SNMP support to handle multiple systems on the same port.
Vincent Bernat [Sun, 24 May 2009 18:23:59 +0000 (20:23 +0200)] 
Fix SNMP support to handle multiple systems on the same port.

14 years agoFix support for EDP with respect to multisystem support.
Vincent Bernat [Sun, 24 May 2009 17:33:28 +0000 (19:33 +0200)] 
Fix support for EDP with respect to multisystem support.
EDP VLAN are transmitted in another VLAN and therefore need to be
attached to the right existing system.

14 years agoAdd some debug output to track know remote systems/ports.
Vincent Bernat [Sun, 24 May 2009 17:16:01 +0000 (19:16 +0200)] 
Add some debug output to track know remote systems/ports.

14 years agoAdapt lldpctl to display received systems for each port.
Vincent Bernat [Sun, 24 May 2009 12:29:15 +0000 (14:29 +0200)] 
Adapt lldpctl to display received systems for each port.

14 years agoHandle reception of several different systems on each port.
Vincent Bernat [Sat, 23 May 2009 17:28:39 +0000 (19:28 +0200)] 
Handle reception of several different systems on each port.

14 years agoUpdate lldpd.h to support a list of remote systems.
Vincent Bernat [Sat, 23 May 2009 14:59:25 +0000 (16:59 +0200)] 
Update lldpd.h to support a list of remote systems.

14 years agoSimplify multiprotocols handling.
Vincent Bernat [Sat, 23 May 2009 13:04:22 +0000 (15:04 +0200)] 
Simplify multiprotocols handling.
Remove probing. This is not very usable for now but this will be
enhanced when we will support multiple systems on the same port.

14 years agoSuppress bond handling.
Vincent Bernat [Mon, 18 May 2009 17:04:57 +0000 (19:04 +0200)] 
Suppress bond handling.
This will be done in another way later.

14 years agoSuppress "listen on vlan" feature.
Vincent Bernat [Thu, 14 May 2009 14:08:05 +0000 (16:08 +0200)] 
Suppress "listen on vlan" feature.
This will be reimplemented later in a more generic way.

14 years agoWhen LLDP-MED is not enabled, do not send inventory.
Vincent Bernat [Sun, 24 May 2009 19:20:42 +0000 (21:20 +0200)] 
When LLDP-MED is not enabled, do not send inventory.

14 years agoKeep gcc happy with 'const' keyword.
Vincent Bernat [Sun, 24 May 2009 18:45:47 +0000 (20:45 +0200)] 
Keep gcc happy with 'const' keyword.
With optimization -O0, gcc seems to handle more carefully 'const'
keyword.

14 years agoUse chassis ID when sending EDP packets.
Vincent Bernat [Sun, 24 May 2009 19:05:04 +0000 (21:05 +0200)] 
Use chassis ID when sending EDP packets.

14 years agoFix EDP vlan handling when there is no VLAN
Vincent Bernat [Sun, 24 May 2009 18:37:30 +0000 (20:37 +0200)] 
Fix EDP vlan handling when there is no VLAN

14 years agoRemove misc/ directory.
Vincent Bernat [Fri, 22 May 2009 18:39:00 +0000 (20:39 +0200)] 
Remove misc/ directory.
This directory is old junk code.

15 years agoFix the case where last change < start time.
Vincent Bernat [Thu, 21 May 2009 08:50:40 +0000 (10:50 +0200)] 
Fix the case where last change < start time.
This case can happen if the master agent is restarted: lldpd last
change will be before the start of the master agent.

15 years agoAdapt .spec file to work with actual tar.gz.
Vincent Bernat [Wed, 20 May 2009 17:50:51 +0000 (19:50 +0200)] 
Adapt .spec file to work with actual tar.gz.
lldpd.init and lldpd.sysconfig should be shipped into src.rpm package.

15 years agoUpdate version in configure.ac 0.4.0
Vincent Bernat [Tue, 19 May 2009 12:42:45 +0000 (14:42 +0200)] 
Update version in configure.ac

15 years agoIf net-snmp/agent/struct.h does not exist, provide an empty one.
Vincent Bernat [Tue, 19 May 2009 12:32:28 +0000 (14:32 +0200)] 
If net-snmp/agent/struct.h does not exist, provide an empty one.

15 years agoAdd init script for RPM
Vincent Bernat [Tue, 19 May 2009 11:03:55 +0000 (13:03 +0200)] 
Add init script for RPM

15 years agoEnhance .spec.
Vincent Bernat [Tue, 19 May 2009 10:06:58 +0000 (12:06 +0200)] 
Enhance .spec.
Enable SNMP support when building RPM.
Create lldpd user/group.

15 years agoFix URL and description to match Debian package.
Vincent Bernat [Mon, 18 May 2009 16:12:41 +0000 (18:12 +0200)] 
Fix URL and description to match Debian package.

15 years agolldpd.spec for RPM package, contributed by Dean Hamstead.
Vincent Bernat [Mon, 18 May 2009 16:12:13 +0000 (18:12 +0200)] 
lldpd.spec for RPM package, contributed by Dean Hamstead.

15 years agoAlso check for VLAN on bridges.
Vincent Bernat [Thu, 14 May 2009 15:56:59 +0000 (17:56 +0200)] 
Also check for VLAN on bridges.

15 years agoSome virtual ethernet interfaces do not have IFF_MULTICAST flag. We
Vincent Bernat [Tue, 17 Mar 2009 14:01:40 +0000 (15:01 +0100)] 
Some virtual ethernet interfaces do not have IFF_MULTICAST flag. We
use them if they have at least the IFF_BROADCAST flag. This is useful
for Xen Dom0 to get LLDP information from DomU.

15 years agoFix a parsing error for link aggregation TLV in LLDP
Vincent Bernat [Tue, 10 Mar 2009 18:57:18 +0000 (19:57 +0100)] 
Fix a parsing error for link aggregation TLV in LLDP

15 years agoAdd missing frame.c
Vincent Bernat [Mon, 9 Mar 2009 09:33:50 +0000 (10:33 +0100)] 
Add missing frame.c

15 years agoWhen cleaning up a port in the context of refreshing gathered
Vincent Bernat [Sun, 8 Mar 2009 15:47:17 +0000 (16:47 +0100)] 
When cleaning up a port in the context of refreshing gathered
information, don't clean LLDP-MED location information. However, when
cleaning up a port for removal, clean them.

This fixes a regression introduced when fixing a memory leak. The
regression was introduced in:
 63f4b177e9b98ee2531e24a584fb7eaa754d0a14

15 years agoFix LLDP-MED class type sending: it is 1 byte large, not 2.
Vincent Bernat [Sun, 8 Mar 2009 15:13:06 +0000 (16:13 +0100)] 
Fix LLDP-MED class type sending: it is 1 byte large, not 2.

15 years agoFix alignment issue that may appear when reading 64bit integers.
Vincent Bernat [Sun, 8 Mar 2009 15:11:13 +0000 (16:11 +0100)] 
Fix alignment issue that may appear when reading 64bit integers.

15 years agoMajor rewrite for packet builder and parser.
Vincent Bernat [Sun, 8 Mar 2009 15:01:22 +0000 (16:01 +0100)] 
Major rewrite for packet builder and parser.

Packet builder now uses POKE_* macro that push bytes one by one using
memcpy to avoid any alignment issue that may appear on architectures
like ARM. The use of those macros instead of IOV renders the code
usually smaller except for very simple protocols.

Packet parser does not use structure casting any more. This is not
safe on architectures that do not handle unaligned read. We now read
packets sequentially using memcpy when reading more than one byte.
This makes the parser harder to read and somewhat longer.

15 years agoFix unaligned memory access in ctl.c using memcpy instead of pointer
Vincent Bernat [Sat, 7 Mar 2009 09:37:29 +0000 (10:37 +0100)] 
Fix unaligned memory access in ctl.c using memcpy instead of pointer
magic. This needs to be done on encoding/decoding too.

15 years agoCall res_init in case of failure to resolv names
Vincent Bernat [Fri, 6 Mar 2009 10:55:30 +0000 (11:55 +0100)] 
Call res_init in case of failure to resolv names

15 years agoFix lldpctl when LLDP-MED is enabled. 0.3.2
Vincent Bernat [Mon, 2 Mar 2009 15:07:06 +0000 (16:07 +0100)] 
Fix lldpctl when LLDP-MED is enabled.
Prepare new release.

15 years agoFix warning when compiling without LLDP-MED
Vincent Bernat [Mon, 2 Mar 2009 15:06:54 +0000 (16:06 +0100)] 
Fix warning when compiling without LLDP-MED

15 years agoPrepare version 0.3.1 0.3.1
Vincent Bernat [Fri, 27 Feb 2009 20:57:20 +0000 (21:57 +0100)] 
Prepare version 0.3.1

15 years agoUse memcpy instead of strlcpy when copying interface names to static
Vincent Bernat [Fri, 27 Feb 2009 13:23:19 +0000 (14:23 +0100)] 
Use memcpy instead of strlcpy when copying interface names to static
buffers.

15 years agoWhen refreshing port information, clean up existing information!
Vincent Bernat [Fri, 27 Feb 2009 13:16:19 +0000 (14:16 +0100)] 
When refreshing port information, clean up existing information!

15 years agoDon't try to reset the interface when removing it
Vincent Bernat [Fri, 27 Feb 2009 13:11:48 +0000 (14:11 +0100)] 
Don't try to reset the interface when removing it

15 years agoFix double free for local ports
Vincent Bernat [Fri, 27 Feb 2009 13:11:19 +0000 (14:11 +0100)] 
Fix double free for local ports

15 years agoFix a memory leak that can happen when a port is removed or renamed
Vincent Bernat [Fri, 27 Feb 2009 12:46:02 +0000 (13:46 +0100)] 
Fix a memory leak that can happen when a port is removed or renamed

15 years agoDon't free c_med_sw for local chassis. It is allocated and freed
Vincent Bernat [Fri, 27 Feb 2009 10:21:05 +0000 (11:21 +0100)] 
Don't free c_med_sw for local chassis. It is allocated and freed
elsewhere.

15 years agoFix an error when reading LLDP-MED packet
Vincent Bernat [Fri, 27 Feb 2009 10:09:20 +0000 (11:09 +0100)] 
Fix an error when reading LLDP-MED packet

15 years agoFix a memory leak when using LLDP-MED
Vincent Bernat [Fri, 27 Feb 2009 10:08:54 +0000 (11:08 +0100)] 
Fix a memory leak when using LLDP-MED

15 years agoLower log level for problem when getting bridge info
Vincent Bernat [Sat, 21 Feb 2009 08:34:56 +0000 (09:34 +0100)] 
Lower log level for problem when getting bridge info

15 years agoAlso check if the interface is RUNNING before considering it active.
Vincent Bernat [Wed, 21 Jan 2009 02:35:48 +0000 (03:35 +0100)] 
Also check if the interface is RUNNING before considering it active.

15 years agoMerge branch 'master' of ssh://ace.luffy.cx/srv/git/lldpd
Vincent Bernat [Fri, 9 Jan 2009 16:03:43 +0000 (17:03 +0100)] 
Merge branch 'master' of ssh://ace.luffy.cx/srv/git/lldpd

15 years agoFix compilation when SONMP and EDP are disabled
Vincent Bernat [Fri, 9 Jan 2009 16:02:32 +0000 (17:02 +0100)] 
Fix compilation when SONMP and EDP are disabled

15 years agoDon't output any warning when bridge support is not enabled at all.
Vincent Bernat [Tue, 30 Dec 2008 16:04:35 +0000 (17:04 +0100)] 
Don't output any warning when bridge support is not enabled at all.

15 years agoFDP seems to use a non-flawed checksum
Vincent Bernat [Fri, 26 Dec 2008 16:41:02 +0000 (17:41 +0100)] 
FDP seems to use a non-flawed checksum

15 years agoDon't compile FDP stuff if not needed.
Vincent Bernat [Fri, 26 Dec 2008 16:18:38 +0000 (17:18 +0100)] 
Don't compile FDP stuff if not needed.

15 years agoFix lldpctl to display capability bit "Router"
Vincent Bernat [Fri, 26 Dec 2008 16:09:29 +0000 (17:09 +0100)] 
Fix lldpctl to display capability bit "Router"

15 years agoHandle FDP capabilities
Vincent Bernat [Fri, 26 Dec 2008 16:06:59 +0000 (17:06 +0100)] 
Handle FDP capabilities

15 years agoUse static for all not to be exported symbols
Vincent Bernat [Fri, 26 Dec 2008 11:12:04 +0000 (12:12 +0100)] 
Use static for all not to be exported symbols

15 years agoMove LLDP-MED location/policy to port instead of chassis.
Vincent Bernat [Tue, 23 Dec 2008 15:16:36 +0000 (16:16 +0100)] 
Move LLDP-MED location/policy to port instead of chassis.
Handle setting of location in lldpctl instead of lldpd.

15 years agoAdding missing values for MAU type, thanks to James Lingard.
Vincent Bernat [Fri, 19 Dec 2008 07:48:14 +0000 (08:48 +0100)] 
Adding missing values for MAU type, thanks to James Lingard.

15 years agoFix compilation without EDP
Vincent Bernat [Thu, 18 Dec 2008 18:44:16 +0000 (19:44 +0100)] 
Fix compilation without EDP

15 years agoHandle reception and display of PVID
Vincent Bernat [Tue, 16 Dec 2008 16:34:02 +0000 (17:34 +0100)] 
Handle reception and display of PVID

15 years agoThis is maximum frame size, not MTU
Vincent Bernat [Tue, 16 Dec 2008 16:09:26 +0000 (17:09 +0100)] 
This is maximum frame size, not MTU

15 years agoAdd Maximum Frame Size support. For Linux, we just use MTU as MFS.
Vincent Bernat [Tue, 16 Dec 2008 10:23:43 +0000 (11:23 +0100)] 
Add Maximum Frame Size support. For Linux, we just use MTU as MFS.

15 years agoFix manual page (missing .El) 0.3
Vincent Bernat [Sun, 14 Dec 2008 11:06:33 +0000 (12:06 +0100)] 
Fix manual page (missing .El)

15 years agoPrepare new 0.3 version
Vincent Bernat [Sun, 14 Dec 2008 10:56:56 +0000 (11:56 +0100)] 
Prepare new 0.3 version

15 years agoAdd a note about the fact that location option could be moved to
Vincent Bernat [Sun, 14 Dec 2008 09:51:25 +0000 (10:51 +0100)] 
Add a note about the fact that location option could be moved to
lldpctl. This will be done when we can keep persistent data.