lib: Fix a buffer underflow in _lldpctl_dump_in_atom

Do not write a zero byte before the beginning of the buffer when
_lldpctl_dump_in_atom is called with a zero length atom.

interfaces: "fix" style issue in latest commit

Depending on the version of clang, we may get different result. This is
annoying, but no time to fix that now.

interfaces: don't use wireless extensions

Fix #579

daemon: rework a bit systemd support

Use connect() as done by other implementations, notably the one in
sd_notify(2). Also add a check on socket length.

build: bump softprops/action-gh-release from 1 to 2

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 25 to 26

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 25 to 26.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v25...v26)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: use pytest-forked to replace boxed feature from xdist

This is needed because of the code switching from one namespace to
another.

build: don't use boxed feature of xdist

It has been removed from 3.0. This could be replaced by pytest-forked if
needed. I don't really remember why I was using that (I suppose it was
to avoid segfaults, due maybe to ctypes?).

build: disable gold linker in CI

This should not be needed anymore nowadays. This is a tentative to fix
the following errors with clang:

    /usr/bin/ld.gold: warning: Cannot export local symbol '__asan_check_load_add_16_RAX'

client: spell fix

docs: man page fixes

build: bump cachix/install-nix-action from 24 to 25

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 24 to 25.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v24...v25)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.22.0 to 0.23.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

docs: man page fixes

changed: network cable -> link

change -M help text in src/daemon/lldpd.c also

osx: update Brew formula

redhat: suppress extra .la file we don't want to install

redhat: fix date in changelog

release: 1.0.18

There is a small regression in support for 802.3BT. People should keep
using 1.0.17 if that's important for them.

build: bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.21.1 to 0.22.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.21.1 to 0.22.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.21.1...v0.22.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

daemon/netlink: fix documentation string

daemon/netlink: use a different socket for changes and queries

There is a race condition when using the same socket for both. We need
to subscribe for changes before getting the current state as we don't
want to miss an update happening while we get the initial state, but if
there is such an update, the Netlink messages we receive may not be the
ones we expect.

Fix #611

compat: add compat.h header to get forward declarations

daemon/priv: no need to define IFALIASZ

It is part of the shipped kernel header. This is a bit odd we did define
it...

daemon/lldpd: do not set interface description continuously

Otherwise, we get a continuous flow of netlink updates.

Fix #623

build: update automake for OpenBSD

build: update BSD versions, add NetBSD

build: keep using xhyve for OpenBSD

See https://github.com/cross-platform-actions/action/issues/73

build: use QEMU for testing FreeBSD/OpenBSD

FreeBSD jobs often fail with a timeout.

build: bump cachix/install-nix-action from 23 to 24

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 23 to 24.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v23...v24)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: improve const correctness and prototype declarations

String literals aren't assigned to non-const char pointers anymore, they
aren't returned via non-const char pointers, const strings aren't passed
arround via non-const pointers etc.

As a side effect, this eliminates all -Wdiscarded-qualifiers warnings.

Symbol visibility is minimized by declaring additional functions
static, i.e those which are only used inside a single translation unit.

Also, a few includes are added such that all non-static function
definitions 'see' their declarations - such that accidental differences
in signatures immedialy yield compile errors or warnings.

A few macros are also modified to emit forward declarations for
non-static functions in order to eliminate noise when compiling with
-Wmissing-prototypes.
However, it might make sense to move those non-static function
definitions from a header into a dedicated translation unit,
at some point.

build: ensure we use -Werror on Linux builds

client: fix style

client: translate dot into the short hostname

as documented in lldpcli(8):

    configure system hostname name

        Override system hostname with the provided value. By default, the
        system name is the FQDN found from the resolved value of uname
        -n.  As a special value, use "." (dot) to use the short hostname
        instead of a FQDN.

build: remove coverity

It is broken, again. The tool still advertises Travis CI, it looks
unmaintained.

daemon/lldpd: fix capitalization in help output

daemon/lldp: fix warning message about out of order TLVs

Fix #616

build: bump docker/login-action from 2 to 3

Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump docker/metadata-action from 4 to 5

Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md)
- [Commits](https://github.com/docker/metadata-action/compare/v4...v5)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.19.0 to 0.21.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.19.0 to 0.21.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.19.0...v0.21.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

lib/lldpctl: fix style

daemon/lldp: restore read support for 802.3BT

As it was said to work for most people, let's keep it. Just remove write
support for now.

build: update nixpkgs

tests/integration: also remove 802.3bt test

lib: bump API/ABI

Due to previous change, it seems safer to bump the API/ABI as it would
be easy to reuse the numbers introduced by 802.3bt.

Fix #404 (as a side-effect)

daemon/lldp: remove support for 802.3bt

It was broken and despite a tentative to fix it, it is unknown if this
is correct. This looks different from the code in Wireshark. Maybe it
was done on an earlier version of 802.3bt? As the standard is not freely
available, I cannot reasonably fix it.

daemon/protocols: fix some 802.3bt stuff

And add some tests.

lldpcli: fix capitalization

client/conf-power: Add support for 803.2bt parameters.

Signed-off-by: Andreas Hofmann <git@andreas-hofmann.org>

build: fix alignment in configure.ac

build: bump docker/setup-buildx-action from 2 to 3 (#608)

build: bump docker/setup-qemu-action from 2 to 3

Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](https://github.com/docker/setup-qemu-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 22 to 23 (#607)

build: bump docker/build-push-action from 4 to 5 (#609)

build: bump actions/checkout from 3 to 4

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

[oss-fuzz] Issue 62435

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

[bug] fix 5193822305648640 and 4673544697806848

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

build: bump cross-platform-actions/action from 0.17.0 to 0.19.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.17.0 to 0.19.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.17.0...v0.19.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.15.0 to 0.17.0 (#595)

build: try another way to workaround problem with brew

brew update is not mandatory, let's try it as a best effort.

build: try to fix CI on MacOS

github: add GitHub sponsorship

build: bump actions/upload-artifact from 1 to 3

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v1...v3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 21 to 22

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 21 to 22.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v21...v22)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.14.0 to 0.15.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

client: do not expose update command when unprivileged

build: rename fuzzing workflow

build: bump cross-platform-actions/action from 0.13.0 to 0.14.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 20 to 21

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 20 to 21.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v20...v21)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: reformat action for fuzzing

[Fuzzing] oss-fuzz cifuzz (#587)

* [Fuzzing] oss-fuzz cifuzz

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

docs: add a NEWS entry about memory leak

daemon: do not start if fuzzing build mode is enabled

Merge pull request #584 from 0x34d/fuzzing

[Fuzzing] updates for oss-fuzz Ideal integration

[Fuzzing] updates for oss-fuzz Ideal integration

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

osx: update homebrew recipe

osx: don't use plist_options

redhat: do not ship .la file in -devel package

release: 1.0.17

build: bump cross-platform-actions/action from 0.10.0 to 0.13.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.10.0 to 0.13.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.10.0...v0.13.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

client: don't output empty lines on configure commands

lib: remove unreachable code

daemon: fix read overflow when parsing CDP addresses

build: bump cachix/install-nix-action from 18 to 20

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 18 to 20.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v18...v20)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

interfaces: fix use of isdigit()

It is expecting an unsigned char. Make a cast.

build: bump cross-platform-actions/action from 0.7.0 to 0.10.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.7.0 to 0.10.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.7.0...v0.10.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump docker/build-push-action from 3 to 4

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: don't run clang build with SNMP support

The flags from net-snmp-config does not work with clang. This is always
a mess.

build: bump cross-platform-actions/action from 0.6.2 to 0.7.0 (#566)

build: fix lldpcli build

build: better integration of fuzz-decode in build process

I need it to reproduce crashs. Get rid of `build.sh` which does not work
with OOT compilation. Move the needed bits inside README. Simplify some
of the flags used.

interfaces: properly initialize ethtool structure

build: make all char unsigned

This is something that may be used by the kernel later. char may be
signed or unsigned depending on the architecture, so catching that may
be difficult without this option.

tests: mark "too_many_vlans" test as unreliable

m4/progname.m4: Include <stdio.h> for printf in lldp_CHECK___PROGNAME

Otherwise the checks always fails with a compiler that does not
support implict function declarations.

tests: give more time to lldpd when handling many VLANs

tests: use prefixlen instead of mask with pyroute2

tests: upgrade pytest and others to more recent versions

tests: fix warnings about format string