From 5134d8882312b08d56add863d2e5875de3a94017 Mon Sep 17 00:00:00 2001 From: Jean-Pierre Tosoni Date: Wed, 22 Jan 2020 12:03:25 +0100 Subject: [PATCH] lldpd: set a 30 seconds lower limit to the safeguard timer This timer is a safeguard to refresh information about all networks interfaces at regular interval, in case there was something wrong with the event-based refresh. When using milliseconds-grained tx-interval, this could happen several times per second, which is not the intended use of the safeguard. To quote Vincent Bernat: "Minimal value of 30 seconds even if we don't have event-based refresh (so outside the if). Most people have the event-based refresh, so lowering the pace for the others should be pretty invisible." --- src/daemon/event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/daemon/event.c b/src/daemon/event.c index c9bf04ab..59a4ac09 100644 --- a/src/daemon/event.c +++ b/src/daemon/event.c @@ -483,6 +483,8 @@ levent_update_and_send(evutil_socket_t fd, short what, void *arg) lldpd_loop(cfg); if (cfg->g_iface_event != NULL) interval_ms *= 20; + if (interval_ms < 30000) + interval_ms = 30000; tv.tv_sec = interval_ms / 1000; tv.tv_usec = (interval_ms % 1000) * 1000; event_add(cfg->g_main_loop, &tv); -- 2.39.2