]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Monitor.c
Merge branch 'master' in devel-3.0
[thirdparty/mdadm.git] / Monitor.c
index 2ea0bc8f4e39767df3adadb13c9e78f3fea17e0e..af531294cc53c908ea7a1b88f7a1e0870c5c62bf 100644 (file)
--- a/Monitor.c
+++ b/Monitor.c
@@ -1,7 +1,7 @@
 /*
  * mdadm - manage Linux "md" devices aka RAID arrays.
  *
- * Copyright (C) 2001-2002 Neil Brown <neilb@cse.unsw.edu.au>
+ * Copyright (C) 2001-2006 Neil Brown <neilb@suse.de>
  *
  *
  *    This program is free software; you can redistribute it and/or modify
 #include       "md_p.h"
 #include       "md_u.h"
 #include       <sys/wait.h>
-#include       <sys/signal.h>
-#include       <values.h>
+#include       <signal.h>
+#include       <limits.h>
 #include       <syslog.h>
 
-static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
-                 int dosyslog);
+static void alert(char *event, char *dev, char *disc, char *mailaddr, char *mailfrom,
+                 char *cmd, int dosyslog);
 
-static char *percentalerts[] = { 
+static char *percentalerts[] = {
        "RebuildStarted",
        "Rebuild20",
        "Rebuild40",
@@ -46,10 +46,15 @@ static char *percentalerts[] = {
        "Rebuild80",
 };
 
+/* The largest number of disks current arrays can manage is 384
+ * This really should be dynamically, but that will have to wait
+ * At least it isn't MD_SB_DISKS.
+ */
+#define MaxDisks 384
 int Monitor(mddev_dev_t devlist,
            char *mailaddr, char *alert_cmd,
            int period, int daemonise, int scan, int oneshot,
-           int dosyslog, char *config, int test, char* pidfile)
+           int dosyslog, int test, char* pidfile)
 {
        /*
         * Every few seconds, scan every md device looking for changes
@@ -101,22 +106,25 @@ int Monitor(mddev_dev_t devlist,
                char *spare_group;
                int active, working, failed, spare, raid;
                int expected_spares;
-               int devstate[MD_SB_DISKS];
-               int devid[MD_SB_DISKS];
+               int devstate[MaxDisks];
+               int devid[MaxDisks];
                int percent;
                struct state *next;
        } *statelist = NULL;
        int finished = 0;
        struct mdstat_ent *mdstat = NULL;
+       char *mailfrom = NULL;
 
        if (!mailaddr) {
-               mailaddr = conf_get_mailaddr(config);
+               mailaddr = conf_get_mailaddr();
                if (mailaddr && ! scan)
                        fprintf(stderr, Name ": Monitor using email address \"%s\" from config file\n",
                               mailaddr);
        }
+       mailfrom = conf_get_mailfrom();
+
        if (!alert_cmd) {
-               alert_cmd = conf_get_program(config);
+               alert_cmd = conf_get_program();
                if (alert_cmd && ! scan)
                        fprintf(stderr, Name ": Monitor using program \"%s\" from config file\n",
                               alert_cmd);
@@ -148,23 +156,26 @@ int Monitor(mddev_dev_t devlist,
                        return 1;
                }
                close(0);
-               open("/dev/null", 3);
+               open("/dev/null", O_RDWR);
                dup2(0,1);
                dup2(0,2);
                setsid();
        }
 
        if (devlist == NULL) {
-               mddev_ident_t mdlist = conf_get_ident(config, NULL);
+               mddev_ident_t mdlist = conf_get_ident(NULL);
                for (; mdlist; mdlist=mdlist->next) {
-                       struct state *st = malloc(sizeof *st);
+                       struct state *st;
+                       if (mdlist->devname == NULL)
+                               continue;
+                       st = malloc(sizeof *st);
                        if (st == NULL)
                                continue;
                        st->devname = strdup(mdlist->devname);
                        st->utime = 0;
                        st->next = statelist;
                        st->err = 0;
-                       st->devnum = MAXINT;
+                       st->devnum = INT_MAX;
                        st->percent = -2;
                        st->expected_spares = mdlist->spare_disks;
                        if (mdlist->spare_group)
@@ -176,7 +187,7 @@ int Monitor(mddev_dev_t devlist,
        } else {
                mddev_dev_t dv;
                for (dv=devlist ; dv; dv=dv->next) {
-                       mddev_ident_t mdlist = conf_get_ident(config, dv->devname);
+                       mddev_ident_t mdlist = conf_get_ident(dv->devname);
                        struct state *st = malloc(sizeof *st);
                        if (st == NULL)
                                continue;
@@ -184,7 +195,7 @@ int Monitor(mddev_dev_t devlist,
                        st->utime = 0;
                        st->next = statelist;
                        st->err = 0;
-                       st->devnum = MAXINT;
+                       st->devnum = INT_MAX;
                        st->percent = -2;
                        st->expected_spares = -1;
                        st->spare_group = NULL;
@@ -207,6 +218,7 @@ int Monitor(mddev_dev_t devlist,
                mdstat = mdstat_read(oneshot?0:1, 0);
 
                for (st=statelist; st; st=st->next) {
+                       struct { int state, major, minor; } info[MaxDisks];
                        mdu_array_info_t array;
                        struct mdstat_ent *mse = NULL, *mse2;
                        char *dev = st->devname;
@@ -214,37 +226,40 @@ int Monitor(mddev_dev_t devlist,
                        unsigned int i;
 
                        if (test)
-                               alert("TestMessage", dev, NULL, mailaddr, alert_cmd, dosyslog);
+                               alert("TestMessage", dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
                        fd = open(dev, O_RDONLY);
                        if (fd < 0) {
                                if (!st->err)
                                        alert("DeviceDisappeared", dev, NULL,
-                                             mailaddr, alert_cmd, dosyslog);
+                                             mailaddr, mailfrom, alert_cmd, dosyslog);
 /*                                     fprintf(stderr, Name ": cannot open %s: %s\n",
                                                dev, strerror(errno));
 */                             st->err=1;
                                continue;
                        }
+                       fcntl(fd, F_SETFD, FD_CLOEXEC);
                        if (ioctl(fd, GET_ARRAY_INFO, &array)<0) {
                                if (!st->err)
                                        alert("DeviceDisappeared", dev, NULL,
-                                             mailaddr, alert_cmd, dosyslog);
+                                             mailaddr, mailfrom, alert_cmd, dosyslog);
 /*                                     fprintf(stderr, Name ": cannot get array info for %s: %s\n",
                                                dev, strerror(errno));
 */                             st->err=1;
                                close(fd);
                                continue;
                        }
-                       if (array.level != 1 && array.level != 5 && array.level != -4 &&
-                               array.level != 6 && array.level != 10) {
+                       /* It's much easier to list what array levels can't
+                        * have a device disappear than all of them that can
+                        */
+                       if (array.level == 0 || array.level == -1) {
                                if (!st->err)
                                        alert("DeviceDisappeared", dev, "Wrong-Level",
-                                             mailaddr, alert_cmd, dosyslog);
+                                             mailaddr, mailfrom, alert_cmd, dosyslog);
                                st->err = 1;
                                close(fd);
                                continue;
                        }
-                       if (st->devnum == MAXINT) {
+                       if (st->devnum == INT_MAX) {
                                struct stat stb;
                                if (fstat(fd, &stb) == 0 &&
                                    (S_IFMT&stb.st_mode)==S_IFBLK) {
@@ -257,7 +272,7 @@ int Monitor(mddev_dev_t devlist,
 
                        for (mse2 = mdstat ; mse2 ; mse2=mse2->next)
                                if (mse2->devnum == st->devnum) {
-                                       mse2->devnum = MAXINT; /* flag it as "used" */
+                                       mse2->devnum = INT_MAX; /* flag it as "used" */
                                        mse = mse2;
                                }
 
@@ -276,48 +291,84 @@ int Monitor(mddev_dev_t devlist,
                            mse &&      /* is in /proc/mdstat */
                            mse->pattern && strchr(mse->pattern, '_') /* degraded */
                                )
-                               alert("DegradedArray", dev, NULL, mailaddr, alert_cmd, dosyslog);
+                               alert("DegradedArray", dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
 
                        if (st->utime == 0 && /* new array */
-                           st->expected_spares > 0 && 
-                           array.spare_disks < st->expected_spares) 
-                               alert("SparesMissing", dev, NULL, mailaddr, alert_cmd, dosyslog);
+                           st->expected_spares > 0 &&
+                           array.spare_disks < st->expected_spares)
+                               alert("SparesMissing", dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
                        if (mse &&
-                           st->percent == -1 && 
+                           st->percent == -1 &&
                            mse->percent >= 0)
-                               alert("RebuildStarted", dev, NULL, mailaddr, alert_cmd, dosyslog);
+                               alert("RebuildStarted", dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
                        if (mse &&
                            st->percent >= 0 &&
                            mse->percent >= 0 &&
                            (mse->percent / 20) > (st->percent / 20))
                                alert(percentalerts[mse->percent/20],
-                                     dev, NULL, mailaddr, alert_cmd, dosyslog);
+                                     dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
 
                        if (mse &&
                            mse->percent == -1 &&
-                           st->percent >= 0)
-                               alert("RebuildFinished", dev, NULL, mailaddr, alert_cmd, dosyslog);
+                           st->percent >= 0) {
+                               /* Rebuild/sync/whatever just finished.
+                                * If there is a number in /mismatch_cnt,
+                                * we should report that.
+                                */
+                               struct mdinfo *sra =
+                                      sysfs_read(-1, st->devnum, GET_MISMATCH);
+                               if (sra && sra->mismatch_cnt > 0) {
+                                       char cnt[40];
+                                       sprintf(cnt, " mismatches found: %d", sra->mismatch_cnt);
+                                       alert("RebuildFinished", dev, cnt, mailaddr, mailfrom, alert_cmd, dosyslog);
+                               } else
+                                       alert("RebuildFinished", dev, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
+                               if (sra)
+                                       free(sra);
+                       }
 
                        if (mse)
                                st->percent = mse->percent;
-                                       
-                       for (i=0; i<MD_SB_DISKS; i++) {
+
+
+                       for (i=0; i<MaxDisks && i <= array.raid_disks + array.nr_disks;
+                            i++) {
                                mdu_disk_info_t disc;
+                               disc.number = i;
+                               if (ioctl(fd, GET_DISK_INFO, &disc) >= 0) {
+                                       info[i].state = disc.state;
+                                       info[i].major = disc.major;
+                                       info[i].minor = disc.minor;
+                               } else
+                                       info[i].major = info[i].minor = 0;
+                       }
+                       close(fd);
+
+                       for (i=0; i<MaxDisks; i++) {
+                               mdu_disk_info_t disc = {0};
                                int newstate=0;
                                int change;
                                char *dv = NULL;
                                disc.number = i;
-                               if (ioctl(fd, GET_DISK_INFO, &disc)>= 0) {
-                                       newstate = disc.state;
-                                       dv = map_dev(disc.major, disc.minor);
-                               } else if (mse &&  mse->pattern && i < strlen(mse->pattern))
+                               if (i > array.raid_disks + array.nr_disks) {
+                                       newstate = 0;
+                                       disc.major = disc.minor = 0;
+                               } else if (info[i].major || info[i].minor) {
+                                       newstate = info[i].state;
+                                       dv = map_dev(info[i].major, info[i].minor, 1);
+                                       disc.state = newstate;
+                                       disc.major = info[i].major;
+                                       disc.minor = info[i].minor;
+                               } else if (mse &&  mse->pattern && i < strlen(mse->pattern)) {
                                        switch(mse->pattern[i]) {
                                        case 'U': newstate = 6 /* ACTIVE/SYNC */; break;
                                        case '_': newstate = 0; break;
                                        }
+                                       disc.major = disc.minor = 0;
+                               }
                                if (dv == NULL && st->devid[i])
                                        dv = map_dev(major(st->devid[i]),
-                                                    minor(st->devid[i]));
+                                                    minor(st->devid[i]), 1);
                                change = newstate ^ st->devstate[i];
                                if (st->utime && change && !st->err) {
                                        if (i < (unsigned)array.raid_disks &&
@@ -325,24 +376,23 @@ int Monitor(mddev_dev_t devlist,
                                             ((st->devstate[i]&change)&(1<<MD_DISK_ACTIVE)) ||
                                             ((st->devstate[i]&change)&(1<<MD_DISK_SYNC)))
                                                )
-                                               alert("Fail", dev, dv, mailaddr, alert_cmd, dosyslog);
+                                               alert("Fail", dev, dv, mailaddr, mailfrom, alert_cmd, dosyslog);
                                        else if (i >= (unsigned)array.raid_disks &&
                                                 (disc.major || disc.minor) &&
                                                 st->devid[i] == makedev(disc.major, disc.minor) &&
                                                 ((newstate&change)&(1<<MD_DISK_FAULTY))
                                                )
-                                               alert("FailSpare", dev, dv, mailaddr, alert_cmd, dosyslog);
+                                               alert("FailSpare", dev, dv, mailaddr, mailfrom, alert_cmd, dosyslog);
                                        else if (i < (unsigned)array.raid_disks &&
                                                 (((st->devstate[i]&change)&(1<<MD_DISK_FAULTY)) ||
                                                  ((newstate&change)&(1<<MD_DISK_ACTIVE)) ||
                                                  ((newstate&change)&(1<<MD_DISK_SYNC)))
                                                )
-                                               alert("SpareActive", dev, dv, mailaddr, alert_cmd, dosyslog);
+                                               alert("SpareActive", dev, dv, mailaddr, mailfrom, alert_cmd, dosyslog);
                                }
-                               st->devstate[i] = disc.state;
+                               st->devstate[i] = newstate;
                                st->devid[i] = makedev(disc.major, disc.minor);
                        }
-                       close(fd);
                        st->active = array.active_disks;
                        st->working = array.working_disks;
                        st->spare = array.spare_disks;
@@ -354,11 +404,11 @@ int Monitor(mddev_dev_t devlist,
                /* now check if there are any new devices found in mdstat */
                if (scan) {
                        struct mdstat_ent *mse;
-                       for (mse=mdstat; mse; mse=mse->next) 
-                               if (mse->devnum != MAXINT &&
-                                   (strcmp(mse->level, "raid1")==0 ||
-                                    strcmp(mse->level, "raid5")==0 ||
-                                    strcmp(mse->level, "multipath")==0)
+                       for (mse=mdstat; mse; mse=mse->next)
+                               if (mse->devnum != INT_MAX &&
+                                   mse->level &&
+                                   (strcmp(mse->level, "raid0")!=0 &&
+                                    strcmp(mse->level, "linear")!=0)
                                        ) {
                                        struct state *st = malloc(sizeof *st);
                                        mdu_array_info_t array;
@@ -370,6 +420,7 @@ int Monitor(mddev_dev_t devlist,
                                            ioctl(fd, GET_ARRAY_INFO, &array)< 0) {
                                                /* no such array */
                                                if (fd >=0) close(fd);
+                                               put_md_name(st->devname);
                                                free(st->devname);
                                                free(st);
                                                continue;
@@ -383,7 +434,9 @@ int Monitor(mddev_dev_t devlist,
                                        st->spare_group = NULL;
                                        st->expected_spares = -1;
                                        statelist = st;
-                                       alert("NewArray", st->devname, NULL, mailaddr, alert_cmd, dosyslog);
+                                       if (test)
+                                               alert("TestMessage", st->devname, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
+                                       alert("NewArray", st->devname, NULL, mailaddr, mailfrom, alert_cmd, dosyslog);
                                        new_found = 1;
                                }
                }
@@ -412,7 +465,7 @@ int Monitor(mddev_dev_t devlist,
                                                        if (fd2>=0) close(fd2);
                                                        continue;
                                                }
-                                               for (d=st2->raid; d<MD_SB_DISKS; d++) {
+                                               for (d=st2->raid; d < MaxDisks; d++) {
                                                        if (st2->devid[d] > 0 &&
                                                            st2->devstate[d] == 0) {
                                                                dev = st2->devid[d];
@@ -420,11 +473,11 @@ int Monitor(mddev_dev_t devlist,
                                                        }
                                                }
                                                if (dev > 0) {
-                                                       if (ioctl(fd2, HOT_REMOVE_DISK, 
+                                                       if (ioctl(fd2, HOT_REMOVE_DISK,
                                                                  (unsigned long)dev) == 0) {
                                                                if (ioctl(fd1, HOT_ADD_DISK,
                                                                          (unsigned long)dev) == 0) {
-                                                                       alert("MoveSpare", st->devname, st2->devname, mailaddr, alert_cmd, dosyslog);
+                                                                       alert("MoveSpare", st->devname, st2->devname, mailaddr, mailfrom, alert_cmd, dosyslog);
                                                                        close(fd1);
                                                                        close(fd2);
                                                                        break;
@@ -450,14 +503,14 @@ int Monitor(mddev_dev_t devlist,
 }
 
 
-static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
+static void alert(char *event, char *dev, char *disc, char *mailaddr, char *mailfrom, char *cmd,
                  int dosyslog)
 {
        int priority;
 
        if (!cmd && !mailaddr) {
                time_t now = time(0);
-              
+
                printf("%1.15s: %s on %s %s\n", ctime(&now)+4, event, dev, disc?disc:"unknown device");
        }
        if (cmd) {
@@ -473,16 +526,21 @@ static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
                        exit(2);
                }
        }
-       if (mailaddr && 
-           (strncmp(event, "Fail", 4)==0 || 
+       if (mailaddr &&
+           (strncmp(event, "Fail", 4)==0 ||
             strncmp(event, "Test", 4)==0 ||
+            strncmp(event, "Spares", 6)==0 ||
             strncmp(event, "Degrade", 7)==0)) {
                FILE *mp = popen(Sendmail, "w");
                if (mp) {
+                       FILE *mdstat;
                        char hname[256];
                        gethostname(hname, sizeof(hname));
                        signal(SIGPIPE, SIG_IGN);
-                       fprintf(mp, "From: " Name " monitoring <root>\n");
+                       if (mailfrom)
+                               fprintf(mp, "From: %s\n", mailfrom);
+                       else
+                               fprintf(mp, "From: " Name " monitoring <root>\n");
                        fprintf(mp, "To: %s\n", mailaddr);
                        fprintf(mp, "Subject: %s event on %s:%s\n\n", event, dev, hname);
 
@@ -491,10 +549,22 @@ static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
 
                        fprintf(mp, "A %s event had been detected on md device %s.\n\n", event, dev);
 
-                       if (disc)
+                       if (disc && disc[0] != ' ')
                                fprintf(mp, "It could be related to component device %s.\n\n", disc);
+                       if (disc && disc[0] == ' ')
+                               fprintf(mp, "Extra information:%s.\n\n", disc);
 
                        fprintf(mp, "Faithfully yours, etc.\n");
+
+                       mdstat = fopen("/proc/mdstat", "r");
+                       if (mdstat) {
+                               char buf[8192];
+                               int n;
+                               fprintf(mp, "\nP.S. The /proc/mdstat file currently contains the following:\n\n");
+                               while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
+                                       n=fwrite(buf, 1, n, mp); /* yes, i don't care about the result */
+                               fclose(mdstat);
+                       }
                        fclose(mp);
                }
 
@@ -511,7 +581,8 @@ static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
                        priority = LOG_CRIT;
                /* Good to know about, but are not failures: */
                else if (strncmp(event, "Rebuild", 7)==0 ||
-                        strncmp(event, "MoveSpare", 9)==0)
+                        strncmp(event, "MoveSpare", 9)==0 ||
+                        strncmp(event, "Spares", 6) != 0)
                        priority = LOG_WARNING;
                /* Everything else: */
                else
@@ -523,3 +594,146 @@ static void alert(char *event, char *dev, char *disc, char *mailaddr, char *cmd,
                        syslog(priority, "%s event detected on md device %s", event, dev);
        }
 }
+
+/* Not really Monitor but ... */
+int Wait(char *dev)
+{
+       struct stat stb;
+       int devnum;
+       int rv = 1;
+
+       if (stat(dev, &stb) != 0) {
+               fprintf(stderr, Name ": Cannot find %s: %s\n", dev,
+                       strerror(errno));
+               return 2;
+       }
+       devnum = stat2devnum(&stb);
+
+       while(1) {
+               struct mdstat_ent *ms = mdstat_read(1, 0);
+               struct mdstat_ent *e;
+
+               for (e=ms ; e; e=e->next)
+                       if (e->devnum == devnum)
+                               break;
+
+               if (!e || e->percent < 0) {
+                       if (e && e->metadata_version &&
+                           strncmp(e->metadata_version, "external:", 9) == 0) {
+                               if (is_subarray(&e->metadata_version[9]))
+                                       ping_monitor(&e->metadata_version[9]);
+                               else
+                                       ping_monitor(devnum2devname(devnum));
+                       }
+                       free_mdstat(ms);
+                       return rv;
+               }
+               free_mdstat(ms);
+               rv = 0;
+               mdstat_wait(5);
+       }
+}
+
+static char *clean_states[] = {
+       "clear", "inactive", "readonly", "read-auto", "clean", NULL };
+
+int WaitClean(char *dev, int verbose)
+{
+       int fd;
+       struct mdinfo *mdi;
+       int rv = 1;
+       int devnum;
+
+       fd = open(dev, O_RDONLY); 
+       if (fd < 0) {
+               if (verbose)
+                       fprintf(stderr, Name ": Couldn't open %s: %s\n", dev, strerror(errno));
+               return 1;
+       }
+
+       devnum = fd2devnum(fd);
+       mdi = sysfs_read(fd, devnum, GET_VERSION|GET_LEVEL|GET_SAFEMODE);
+       if (!mdi) {
+               if (verbose)
+                       fprintf(stderr, Name ": Failed to read sysfs attributes for "
+                               "%s\n", dev);
+               close(fd);
+               return 0;
+       }
+
+       switch(mdi->array.level) {
+       case LEVEL_LINEAR:
+       case LEVEL_MULTIPATH:
+       case 0:
+               /* safemode delay is irrelevant for these levels */
+               rv = 0;
+               
+       }
+
+       /* for internal metadata the kernel handles the final clean
+        * transition, containers can never be dirty
+        */
+       if (!is_subarray(mdi->text_version))
+               rv = 0;
+
+       /* safemode disabled ? */
+       if (mdi->safe_mode_delay == 0)
+               rv = 0;
+
+       if (rv) {
+               int state_fd = sysfs_open(fd2devnum(fd), NULL, "array_state");
+               char buf[20];
+               fd_set fds;
+               struct timeval tm;
+
+               /* minimize the safe_mode_delay and prepare to wait up to 5s
+                * for writes to quiesce
+                */
+               sysfs_set_safemode(mdi, 1);
+               tm.tv_sec = 5;
+               tm.tv_usec = 0;
+
+               /* give mdmon a chance to checkpoint resync */
+               sysfs_set_str(mdi, NULL, "sync_action", "idle");
+
+               FD_ZERO(&fds);
+
+               /* wait for array_state to be clean */
+               while (1) {
+                       rv = read(state_fd, buf, sizeof(buf));
+                       if (rv < 0)
+                               break;
+                       if (sysfs_match_word(buf, clean_states) <= 4)
+                               break;
+                       FD_SET(state_fd, &fds);
+                       rv = select(state_fd + 1, &fds, NULL, NULL, &tm);
+                       if (rv < 0 && errno != EINTR)
+                               break;
+                       lseek(state_fd, 0, SEEK_SET);
+               }
+               if (rv < 0)
+                       rv = 1;
+               else if (ping_monitor(mdi->text_version) == 0) {
+                       /* we need to ping to close the window between array
+                        * state transitioning to clean and the metadata being
+                        * marked clean
+                        */
+                       rv = 0;
+               } else
+                       rv = 1;
+               if (rv && verbose)
+                       fprintf(stderr, Name ": Error waiting for %s to be clean\n",
+                               dev);
+
+               /* restore the original safe_mode_delay */
+               sysfs_set_safemode(mdi, mdi->safe_mode_delay);
+               close(state_fd);
+       }
+
+       sysfs_free(mdi);
+       close(fd);
+
+       return rv;
+}
+
+