]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - mdadm.c
mdadm-1.6.0
[thirdparty/mdadm.git] / mdadm.c
diff --git a/mdadm.c b/mdadm.c
index 95e7005a9c40920ca9132a973f94ec4390a2205d..827f334d9da146437f3c4c07c8dc9080ba687f91 100644 (file)
--- a/mdadm.c
+++ b/mdadm.c
 
 #include "mdadm.h"
 #include "md_p.h"
+#include <ctype.h>
 
-int open_mddev(char *dev)
+
+void make_parts(char *dev, int cnt)
+{
+       /* make 'cnt' partition devices for 'dev'
+        * We use the major/minor from dev and add 1..cnt
+        * If dev ends with a digit, we add "_p%d" else "%d"
+        * If the name exists, we use it's owner/mode,
+        * else that of dev
+        */
+       struct stat stb;
+       int major, minor;
+       int i;
+       char *name = malloc(strlen(dev) + 20);
+       int dig = isdigit(dev[strlen(dev)-1]);
+
+       if (stat(dev, &stb)!= 0)
+               return;
+       if (!S_ISBLK(stb.st_mode))
+               return;
+       major = MAJOR(stb.st_rdev);
+       minor = MINOR(stb.st_rdev);
+       for (i=1; i <= cnt ; i++) {
+               struct stat stb2;
+               sprintf(name, "%s%s%d", dev, dig?"_p":"", i);
+               if (stat(name, &stb2)==0) {
+                       if (!S_ISBLK(stb2.st_mode))
+                               continue;
+                       if (stb2.st_rdev == MKDEV(major, minor+i))
+                               continue;
+                       unlink(name);
+               } else {
+                       stb2 = stb;
+               }
+               mknod(name, S_IFBLK | 0600, MKDEV(major, minor+i));
+               chown(name, stb2.st_uid, stb2.st_gid);
+               chmod(name, stb2.st_mode & 07777);
+       }
+}
+
+/*
+ * Open a given md device, and check that it really is one.
+ * If 'autof' is given, then we need to create, or recreate, the md device.
+ * If the name already exists, and is not a block device, we fail.
+ * If it exists and is not an md device, is not the right type (partitioned or not),
+ * or is currently in-use, we remove the device, but remember the owner and mode.
+ * If it now doesn't exist, we find a few md array and create the device.
+ * Default ownership is user=0, group=0 perm=0600
+ */
+int open_mddev(char *dev, int autof)
 {
-       int mdfd = open(dev, O_RDWR, 0);
+       int mdfd;
+       struct stat stb;
+       int major = MD_MAJOR;
+       int minor;
+       int must_remove = 0;
+       struct mdstat_ent *mdlist;
+       int num;
+
+       if (autof) {
+               /* autof is set, so we need to check that the name is ok,
+                * and possibly create one if not
+                */
+               stb.st_mode = 0;
+               if (lstat(dev, &stb)==0 && ! S_ISBLK(stb.st_mode)) {
+                       fprintf(stderr, Name ": %s is not a block device.\n",
+                               dev);
+                       return -1;
+               }
+               /* check major number is correct */
+               if (autof>0)
+                       major = get_mdp_major();
+               if (stb.st_mode && MAJOR(stb.st_rdev) != major)
+                       must_remove = 1;
+               if (stb.st_mode && !must_remove) {
+                       mdu_array_info_t array;
+                       /* looks ok, see if it is available */
+                       mdfd = open(dev, O_RDWR, 0);
+                       if (mdfd < 0) {
+                               fprintf(stderr, Name ": error opening %s: %s\n",
+                                       dev, strerror(errno));
+                               return -1;
+                       } else if (md_get_version(mdfd) <= 0) {
+                               fprintf(stderr, Name ": %s does not appear to be an md device\n",
+                                       dev);
+                               close(mdfd);
+                               return -1;
+                       }
+                       if (ioctl(mdfd, GET_ARRAY_INFO, &array)==0) {
+                               /* already active */
+                               must_remove = 1;
+                               close(mdfd);
+                       } else {
+                               if (autof > 0)
+                                       make_parts(dev, autof);
+                               return mdfd;
+                       }
+               }
+               /* Ok, need to find a minor that is not in use.
+                * Easiest to read /proc/mdstat, and hunt through for
+                * an unused number 
+                */
+               mdlist = mdstat_read(0);
+               for (num= (autof>0)?-1:0 ; ; num+= (autof>2)?-1:1) {
+                       struct mdstat_ent *me;
+                       for (me=mdlist; me; me=me->next)
+                               if (me->devnum == num)
+                                       break;
+                       if (!me) {
+                               /* doesn't exist if mdstat.
+                                * make sure it is new to /dev too
+                                */
+                               char *dn;
+                               if (autof > 0) 
+                                       minor = (-1-num) << MdpMinorShift;
+                               else
+                                       minor = num;
+                               dn = map_dev(major,minor);
+                               if (dn==NULL || is_standard(dn)) {
+                                       /* this number only used by a 'standard' name,
+                                        * so it is safe to use
+                                        */
+                                       break;
+                               }
+                       }
+               }
+               /* 'num' is the number to use, >=0 for md, <0 for mdp */
+               if (must_remove) {
+                       /* never remove a device name that ends /mdNN or /dNN,
+                        * that would be confusing 
+                        */
+                       if (is_standard(dev)) {
+                               fprintf(stderr, Name ": --auto refusing to remove %s as it looks like a standard name.\n",
+                                       dev);
+                               return -1;
+                       }
+                       unlink(dev);
+               }
+
+               if (mknod(dev, S_IFBLK|0600, MKDEV(major, minor))!= 0) {
+                       fprintf(stderr, Name ": failed to create %s\n", dev);
+                       return -1;
+               }
+               if (must_remove) {
+                       chown(dev, stb.st_uid, stb.st_gid);
+                       chmod(dev, stb.st_mode & 07777);
+               }
+               make_parts(dev,autof);
+       }
+       mdfd = open(dev, O_RDWR, 0);
        if (mdfd < 0)
                fprintf(stderr, Name ": error opening %s: %s\n",
                        dev, strerror(errno));
@@ -57,14 +204,15 @@ int main(int argc, char *argv[])
        int rv;
 
        int chunk = 0;
-       int size = 0;
-       int level = -10;
-       int layout = -1;
+       int size = -1;
+       int level = UnSet;
+       int layout = UnSet;
        int raiddisks = 0;
        int sparedisks = 0;
        struct mddev_ident_s ident;
        char *configfile = NULL;
        char *cp;
+       char *update = NULL;
        int scan = 0;
        char devmode = 0;
        int runstop = 0;
@@ -77,17 +225,22 @@ int main(int argc, char *argv[])
        int verbose = 0;
        int brief = 0;
        int force = 0;
+       int test = 0;
+       int assume_clean = 0;
+       int autof = 0; /* -1 for non-partitions, 1 or more to create partitions */
 
        char *mailaddr = NULL;
        char *program = NULL;
        int delay = 0;
+       int daemonise = 0;
+       int oneshot = 0;
 
        int mdfd = -1;
 
        ident.uuid_set=0;
-       ident.level = -10;
-       ident.raid_disks = -1;
-       ident.super_minor= -1;
+       ident.level = UnSet;
+       ident.raid_disks = UnSet;
+       ident.super_minor= UnSet;
        ident.devices=0;
 
        while ((option_index = -1) ,
@@ -99,14 +252,19 @@ int main(int argc, char *argv[])
                switch(opt) {
                case 'h':
                        help_text = Help;
-                       switch (mode) {
-                       case ASSEMBLE : help_text = Help_assemble; break;
-                       case BUILD    : help_text = Help_build; break;
-                       case CREATE   : help_text = Help_create; break;
-                       case MANAGE   : help_text = Help_manage; break;
-                       case MISC     : help_text = Help_misc; break;
-                       case MONITOR  : help_text = Help_monitor; break;
-                       }
+                       if (option_index > 0 && 
+                           strcmp(long_options[option_index].name, "help-options")==0)
+                               help_text = OptionHelp;
+                       else
+                               switch (mode) {
+                               case ASSEMBLE : help_text = Help_assemble; break;
+                               case BUILD    : help_text = Help_build; break;
+                               case CREATE   : help_text = Help_create; break;
+                               case MANAGE   : help_text = Help_manage; break;
+                               case MISC     : help_text = Help_misc; break;
+                               case MONITOR  : help_text = Help_monitor; break;
+                               case GROW     : help_text = Help_grow; break;
+                               }
                        fputs(help_text,stderr);
                        exit(0);
 
@@ -142,6 +300,7 @@ int main(int argc, char *argv[])
                case 'B': newmode = BUILD; break;
                case 'C': newmode = CREATE; break;
                case 'F': newmode = MONITOR;break;
+               case 'G': newmode = GROW; break;
 
                case '#':
                case 'D':
@@ -192,13 +351,14 @@ int main(int argc, char *argv[])
                case 'B':
                case 'C':
                case 'F':
+               case 'G':
                        continue;
                }
                if (opt == 1) {
                        /* an undecorated option - must be a device name.
                         */
                        if (devs_found > 0 && mode == '@' && !devmode) {
-                               fprintf(stderr, Name ": Must give on of -a/-r/-f for subsequent devices at %s\n", optarg);
+                               fprintf(stderr, Name ": Must give one of -a/-r/-f for subsequent devices at %s\n", optarg);
                                exit(2);
                        }
                        dv = malloc(sizeof(*dv));
@@ -235,34 +395,39 @@ int main(int argc, char *argv[])
                        }
                        continue;
 
+               case O(GROW,'z'):
                case O(CREATE,'z'): /* size */
-                       if (size) {
+                       if (size >= 0) {
                                fprintf(stderr, Name ": size may only be specified once. "
                                        "Second value is %s.\n", optarg);
                                exit(2);
                        }
-                       size = strtol(optarg, &c, 10);
-                       if (!optarg[0] || *c || size < 4) {
-                               fprintf(stderr, Name ": invalid size: %s\n",
-                                       optarg);
-                               exit(2);
+                       if (strcmp(optarg, "max")==0)
+                               size = 0;
+                       else {
+                               size = strtol(optarg, &c, 10);
+                               if (!optarg[0] || *c || size < 4) {
+                                       fprintf(stderr, Name ": invalid size: %s\n",
+                                               optarg);
+                                       exit(2);
+                               }
                        }
                        continue;
 
                case O(CREATE,'l'):
                case O(BUILD,'l'): /* set raid level*/
-                       if (level != -10) {
+                       if (level != UnSet) {
                                fprintf(stderr, Name ": raid level may only be set once.  "
                                        "Second value is %s.\n", optarg);
                                exit(2);
                        }
                        level = map_name(pers, optarg);
-                       if (level == -10) {
+                       if (level == UnSet) {
                                fprintf(stderr, Name ": invalid raid level: %s\n",
                                        optarg);
                                exit(2);
                        }
-                       if (level != 0 && level != -1 && mode == BUILD) {
+                       if (level != 0 && level != -1 && level != 1 && level != -4 && mode == BUILD) {
                                fprintf(stderr, Name ": Raid level %s not permitted with --build.\n",
                                        optarg);
                                exit(2);
@@ -286,13 +451,14 @@ int main(int argc, char *argv[])
                                fprintf(stderr, Name ": layout not meaningful for %s arrays.\n",
                                        map_num(pers, level));
                                exit(2);
-                       case -10:
+                       case UnSet:
                                fprintf(stderr, Name ": raid level must be given before layout.\n");
                                exit(2);
 
                        case 5:
+                       case 6:
                                layout = map_name(r5layout, optarg);
-                               if (layout==-10) {
+                               if (layout==UnSet) {
                                        fprintf(stderr, Name ": layout %s not understood for raid5.\n",
                                                optarg);
                                        exit(2);
@@ -301,6 +467,12 @@ int main(int argc, char *argv[])
                        }
                        continue;
 
+               case O(CREATE,3):
+               case O(BUILD,3): /* assume clean */
+                       assume_clean = 1;
+                       continue;
+
+               case O(GROW,'n'):
                case O(CREATE,'n'):
                case O(BUILD,'n'): /* number of raid disks */
                        if (raiddisks) {
@@ -314,6 +486,12 @@ int main(int argc, char *argv[])
                                        optarg);
                                exit(2);
                        }
+                       if (raiddisks == 1 &&  !force) {
+                               fprintf(stderr, Name ": '1' is an unusual number of drives for an array, so it is probably\n"
+                                       "     a mistake.  If you really mean it you will need to specify --force before\n"
+                                       "     setting the number of drives.\n");
+                               exit(2);
+                       }
                        ident.raid_disks = raiddisks;
                        continue;
 
@@ -323,7 +501,7 @@ int main(int argc, char *argv[])
                                        sparedisks, optarg);
                                exit(2);
                        }
-                       if (level > -10 && level <= 0 && level >= -1) {
+                       if (level != UnSet && level <= 0 && level >= -1) {
                                fprintf(stderr, Name ": spare-devices setting is incompatible with raid level %d\n",
                                        level);
                                exit(2);
@@ -335,6 +513,44 @@ int main(int argc, char *argv[])
                                exit(2);
                        }
                        continue;
+
+               case O(CREATE,'a'):
+               case O(BUILD,'a'):
+               case O(ASSEMBLE,'a'): /* auto-creation of device node */
+                       if (optarg == NULL)
+                               autof = -1;
+                       else if (strcasecmp(optarg,"no")==0)
+                               autof = 0;
+                       else if (strcasecmp(optarg,"yes")==0 || strcasecmp(optarg,"md")==0)
+                               autof = -1;
+                       else {
+                               /* There might be digits, and maybe a hypen, at the end */
+                               char *e = optarg + strlen(optarg);
+                               int num = 4;
+                               int len;
+                               while (e > optarg && isdigit(e[-1]))
+                                       e--;
+                               if (*e) {
+                                       num = atoi(e);
+                                       if (num <= 0) num = 1;
+                               }
+                               if (e > optarg && e[-1] == '-')
+                                       e--;
+                               len = e - optarg;
+                               if ((len == 3 && strncasecmp(optarg,"mdp",3)==0) ||
+                                   (len == 1 && strncasecmp(optarg,"p",1)==0) ||
+                                   (len >= 4 && strncasecmp(optarg,"part",4)==0))
+                                       autof = num;
+                               else {
+                                       fprintf(stderr, Name ": --auto flag arg of \"%s\" unrecognised: use no,yes,md,mdp,part\n"
+                                               "        optionally followed by a number.\n",
+                                               optarg);
+                                       exit(2);
+                               }
+                       }
+                       continue;
+
+               case O(BUILD,'f'): /* force honouring '-n 1' */
                case O(CREATE,'f'): /* force honouring of device list */
                case O(ASSEMBLE,'f'): /* force assembly */
                case O(MISC,'f'): /* force zero */
@@ -357,18 +573,37 @@ int main(int argc, char *argv[])
                        continue;
 
                case O(ASSEMBLE,'m'): /* super-minor for array */
-                       if (ident.super_minor >= 0) {
+                       if (ident.super_minor != UnSet) {
                                fprintf(stderr, Name ": super-minor cannot be set twice.  "
                                        "Second value: %s.\n", optarg);
                                exit(2);
                        }
-                       ident.super_minor = strtoul(optarg, &cp, 10);
-                       if (!optarg[0] || *cp) {
-                               fprintf(stderr, Name ": Bad super-minor number: %s.\n", optarg);
-                               exit(2);
+                       if (strcmp(optarg, "dev")==0)
+                               ident.super_minor = -2;
+                       else {
+                               ident.super_minor = strtoul(optarg, &cp, 10);
+                               if (!optarg[0] || *cp) {
+                                       fprintf(stderr, Name ": Bad super-minor number: %s.\n", optarg);
+                                       exit(2);
+                               }
                        }
                        continue;
 
+               case O(ASSEMBLE,'U'): /* update the superblock */
+                       if (update) {
+                               fprintf(stderr, Name ": Can only update one aspect of superblock, both %s and %s given.\n",
+                                       update, optarg);
+                               exit(2);
+                       }
+                       update = optarg;
+                       if (strcmp(update, "sparc2.2")==0) continue;
+                       if (strcmp(update, "super-minor") == 0)
+                               continue;
+                       if (strcmp(update, "summaries")==0)
+                               continue;
+                       fprintf(stderr, Name ": '--update %s' invalid.  Only 'sparc2.2', 'super-minor' or 'summaries' supported\n",update);
+                       exit(2);
+
                case O(ASSEMBLE,'c'): /* config file */
                case O(MISC, 'c'):
                case O(MONITOR,'c'):
@@ -415,15 +650,20 @@ int main(int argc, char *argv[])
                                }
                        }
                        continue;
-                       
+               case O(MONITOR,'f'): /* daemonise */
+                       daemonise = 1;
+                       continue;
+               case O(MONITOR,'1'): /* oneshot */
+                       oneshot = 1;
+                       continue;
+               case O(MONITOR,'t'): /* test */
+                       test = 1;
+                       continue;
 
                        /* now the general management options.  Some are applicable
                         * to other modes. None have arguments.
                         */
-               case O(MANAGE,'a'):
-               case O(CREATE,'a'):
-               case O(BUILD,'a'):
-               case O(ASSEMBLE,'a'): /* add a drive */
+               case O(MANAGE,'a'): /* add a drive */
                        devmode = 'a';
                        continue;
                case O(MANAGE,'r'): /* remove a drive */
@@ -481,6 +721,9 @@ int main(int argc, char *argv[])
                        }
                        devmode = opt;
                        continue;
+               case O(MISC,'t'):
+                       test = 1;
+                       continue;
 
                case O(MISC, 22):
                        if (devmode != 'E') {
@@ -489,13 +732,6 @@ int main(int argc, char *argv[])
                        }
                        SparcAdjust = 1;
                        continue;
-               case O(MISC,23):
-                       if (devmode != 'E') {
-                               fprintf(stderr, Name ": --sparc2.2update only allowed with --examine\n");
-                               exit(2);
-                       }
-                       SparcAdjust = 2;
-                       continue;
                }
                /* We have now processed all the valid options. Anything else is
                 * an error
@@ -520,14 +756,24 @@ int main(int argc, char *argv[])
         * we check that here and open it.
         */
 
-       if (mode==MANAGE || mode == BUILD || mode == CREATE || (mode == ASSEMBLE && ! scan)) {
+       if (mode==MANAGE || mode == BUILD || mode == CREATE || mode == GROW ||
+           (mode == ASSEMBLE && ! scan)) {
                if (devs_found < 1) {
                        fprintf(stderr, Name ": an md device must be given in this mode\n");
                        exit(2);
                }
-               mdfd = open_mddev(devlist->devname);
+               if ((int)ident.super_minor == -2 && autof) {
+                       fprintf(stderr, Name ": --super-minor=dev is incompatible with --auto\n");      
+                       exit(2);
+               }
+               mdfd = open_mddev(devlist->devname, autof);
                if (mdfd < 0)
                        exit(1);
+               if ((int)ident.super_minor == -2) {
+                       struct stat stb;
+                       fstat(mdfd, &stb);
+                       ident.super_minor = MINOR(stb.st_rdev);
+               }
        }
 
        rv = 0;
@@ -545,14 +791,36 @@ int main(int argc, char *argv[])
                        rv = Manage_runstop(devlist->devname, mdfd, runstop);
                break;
        case ASSEMBLE:
-               if (!scan)
+               if (devs_found == 1 && ident.uuid_set == 0 &&
+                   ident.super_minor == UnSet && !scan ) {
+                       /* Only a device has been given, so get details from config file */
+                       mddev_ident_t array_ident = conf_get_ident(configfile, devlist->devname);
+                       mdfd = open_mddev(devlist->devname, array_ident->autof);
+                       if (mdfd < 0)
+                               rv |= 1;
+                       else {
+                               if (array_ident == NULL) {
+                                       fprintf(stderr, Name ": %s not identified in config file.\n",
+                                               devlist->devname);
+                                       rv |= 1;
+                               }
+                               else 
+                                       rv |= Assemble(devlist->devname, mdfd, array_ident, configfile,
+                                                      NULL,
+                                                      readonly, runstop, update, verbose, force);
+                       }
+               } else if (!scan)
                        rv = Assemble(devlist->devname, mdfd, &ident, configfile,
                                      devlist->next,
-                                     readonly, runstop, verbose, force);
-               else if (devs_found>0)
+                                     readonly, runstop, update, verbose, force);
+               else if (devs_found>0) {
+                       if (update && devs_found > 1) {
+                               fprintf(stderr, Name ": can only update a single array at a time\n");
+                               exit(1);
+                       }
                        for (dv = devlist ; dv ; dv=dv->next) {
                                mddev_ident_t array_ident = conf_get_ident(configfile, dv->devname);
-                               mdfd = open_mddev(dv->devname);
+                               mdfd = open_mddev(dv->devname, array_ident->autof);
                                if (mdfd < 0) {
                                        rv |= 1;
                                        continue;
@@ -565,9 +833,9 @@ int main(int argc, char *argv[])
                                }
                                rv |= Assemble(dv->devname, mdfd, array_ident, configfile,
                                               NULL,
-                                              readonly, runstop, verbose, force);
+                                              readonly, runstop, update, verbose, force);
                        }
-               else {
+               else {
                        mddev_ident_t array_list =  conf_get_ident(configfile, NULL);
                        if (!array_list) {
                                fprintf(stderr, Name ": No arrays found in config file\n");
@@ -575,7 +843,7 @@ int main(int argc, char *argv[])
                        } else
                                for (; array_list; array_list = array_list->next) {
                                        mdu_array_info_t array;
-                                       mdfd = open_mddev(array_list->devname);
+                                       mdfd = open_mddev(array_list->devname, array_list->autof);
                                        if (mdfd < 0) {
                                                rv |= 1;
                                                continue;
@@ -586,15 +854,15 @@ int main(int argc, char *argv[])
                                        rv |= Assemble(array_list->devname, mdfd,
                                                       array_list, configfile,
                                                       NULL,
-                                                      readonly, runstop, verbose, force);
+                                                      readonly, runstop, NULL, verbose, force);
                                }
                }
                break;
        case BUILD:
-               rv = Build(devlist->devname, mdfd, chunk, level, raiddisks, devlist->next);
+               rv = Build(devlist->devname, mdfd, chunk, level, raiddisks, devlist->next, assume_clean);
                break;
        case CREATE:
-               rv = Create(devlist->devname, mdfd, chunk, level, layout, size,
+               rv = Create(devlist->devname, mdfd, chunk, level, layout, size<0 ? 0 : size,
                            raiddisks, sparedisks,
                            devs_found-1, devlist->next, runstop, verbose, force);
                break;
@@ -616,7 +884,7 @@ int main(int argc, char *argv[])
                        if (devlist == NULL) {
                                if ((devmode == 'S' ||devmode=='D') && scan) {
                                        /* apply to all devices in /proc/mdstat */
-                                       struct mdstat_ent *ms = mdstat_read();
+                                       struct mdstat_ent *ms = mdstat_read(0);
                                        struct mdstat_ent *e;
                                        for (e=ms ; e ; e=e->next) {
                                                char *name = get_md_name(e->devnum);
@@ -627,9 +895,9 @@ int main(int argc, char *argv[])
                                                        continue;
                                                }
                                                if (devmode == 'D')
-                                                       rv |= Detail(name, !verbose);
+                                                       rv |= Detail(name, !verbose, test);
                                                else if (devmode=='S') {
-                                                       mdfd = open_mddev(name);
+                                                       mdfd = open_mddev(name, 0);
                                                        if (mdfd >= 0)
                                                                rv |= Manage_runstop(name, mdfd, -1);
                                                }
@@ -643,13 +911,13 @@ int main(int argc, char *argv[])
                        for (dv=devlist ; dv; dv=dv->next) {
                                switch(dv->disposition) {
                                case 'D':
-                                       rv |= Detail(dv->devname, brief); continue;
+                                       rv |= Detail(dv->devname, brief, test); continue;
                                case 'K': /* Zero superblock */
                                        rv |= Kill(dv->devname, force); continue;
                                case 'Q':
                                        rv |= Query(dv->devname); continue;
                                }
-                               mdfd = open_mddev(dv->devname);
+                               mdfd = open_mddev(dv->devname, 0);
                                if (mdfd>=0)
                                        switch(dv->disposition) {
                                        case 'R':
@@ -665,14 +933,27 @@ int main(int argc, char *argv[])
                }
                break;
        case MONITOR:
-/*
                if (!devlist && !scan) {
                        fprintf(stderr, Name ": Cannot monitor: need --scan or at least one device\n");
                        rv = 1;
                        break;
                }
-*/             rv= Monitor(devlist, mailaddr, program,
-                           delay?delay:60, scan, configfile);
+               rv= Monitor(devlist, mailaddr, program,
+                           delay?delay:60, daemonise, scan, oneshot, configfile, test);
+               break;
+
+       case GROW:
+               if (devs_found > 1) {
+                       fprintf(stderr, Name ": Only one device may be given for --grow\n");
+                       rv = 1;
+                       break;
+               }
+               if (size >= 0 && raiddisks) {
+                       fprintf(stderr, Name ": can only grow size OR raiddisks, not both\n");
+                       rv = 1;
+                       break;
+               }
+               rv = Manage_resize(devlist->devname, mdfd, size, raiddisks);
                break;
        }
        exit(rv);