]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - super-ddf.c
Report uuid in --detail --brief for ddf and intel
[thirdparty/mdadm.git] / super-ddf.c
index f29b8bf2ac9c67a8880fe70eda6de0649cc65e53..ad21e74a3c82fee0ded5074d1b737ac921b330db 100644 (file)
@@ -426,8 +426,9 @@ struct ddf_super {
                        };
                };
                struct disk_data disk;
+               void *mdupdate; /* hold metadata update */
                struct vcl *vlist[0]; /* max_part in size */
-       } *dlist;
+       } *dlist, *add_list;
 };
 
 #ifndef offsetof
@@ -813,6 +814,7 @@ static int load_super_ddf(struct supertype *st, int fd,
                st->minor_version = 0;
                st->max_devs = 512;
        }
+       st->loaded_container = 0;
        return 0;
 
 }
@@ -1098,20 +1100,18 @@ static void examine_super_ddf(struct supertype *st, char *homehost)
        examine_pds(sb);
 }
 
+static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info);
+
+
 static void brief_examine_super_ddf(struct supertype *st)
 {
        /* We just write a generic DDF ARRAY entry
-        * The uuid is all hex, 6 groups of 4 bytes
         */
-       struct ddf_super *ddf = st->sb;
-       int i;
-       printf("ARRAY /dev/ddf metadata=ddf UUID=");
-       for (i = 0; i < DDF_GUID_LEN; i++) {
-               if ((i&3) == 0 && i != 0)
-                       printf(":");
-               printf("%02X", 255&ddf->anchor.guid[i]);
-       }
-       printf("\n");
+       struct mdinfo info;
+       char nbuf[64];
+       getinfo_super_ddf(st, &info);
+       fname_from_uuid(st, &info, nbuf, ':');
+       printf("ARRAY /dev/ddf metadata=ddf UUID=%s\n", nbuf + 5);
 }
 
 static void detail_super_ddf(struct supertype *st, char *homehost)
@@ -1130,6 +1130,11 @@ static void brief_detail_super_ddf(struct supertype *st)
         * Can that be stored in ddf_super??
         */
 //     struct ddf_super *ddf = st->sb;
+       struct mdinfo info;
+       char nbuf[64];
+       getinfo_super_ddf(st, &info);
+       fname_from_uuid(st, &info, nbuf,':');
+       printf(" UUID=%s", nbuf + 5);
 }
 #endif
 
@@ -1148,6 +1153,7 @@ static int match_home_ddf(struct supertype *st, char *homehost)
                ddf->controller.vendor_data[len] == 0);
 }
 
+#ifndef MDASSEMBLE
 static struct vd_config *find_vdcr(struct ddf_super *ddf, int inst)
 {
        struct vcl *v;
@@ -1157,6 +1163,7 @@ static struct vd_config *find_vdcr(struct ddf_super *ddf, int inst)
                        return &v->conf;
        return NULL;
 }
+#endif
 
 static int find_phys(struct ddf_super *ddf, __u32 phys_refnum)
 {
@@ -1176,11 +1183,14 @@ static void uuid_from_super_ddf(struct supertype *st, int uuid[4])
         *  uuid to put into bitmap file (Create, Grow)
         *  uuid for backup header when saving critical section (Grow)
         *  comparing uuids when re-adding a device into an array
+        *    In these cases the uuid required is that of the data-array,
+        *    not the device-set.
+        *  uuid to recognise same set when adding a missing device back
+        *    to an array.   This is a uuid for the device-set.
+        *  
         * For each of these we can make do with a truncated
         * or hashed uuid rather than the original, as long as
         * everyone agrees.
-        * In each case the uuid required is that of the data-array,
-        * not the device-set.
         * In the case of SVD we assume the BVD is of interest,
         * though that might be the case if a bitmap were made for
         * a mirrored SVD - worry about that later.
@@ -1190,19 +1200,21 @@ static void uuid_from_super_ddf(struct supertype *st, int uuid[4])
         */
        struct ddf_super *ddf = st->sb;
        struct vcl *vcl = ddf->currentconf;
+       char *guid;
+       char buf[20];
+       struct sha1_ctx ctx;
 
-       if (!vcl)
-               memset(uuid, 0, sizeof (uuid));
-       else {
-               char buf[20];
-               struct sha1_ctx ctx;
-               sha1_init_ctx(&ctx);
-               sha1_process_bytes(&vcl->conf.guid, DDF_GUID_LEN, &ctx);
-               if (vcl->conf.sec_elmnt_count > 1)
-                       sha1_process_bytes(&vcl->conf.sec_elmnt_seq, 1, &ctx);
-               sha1_finish_ctx(&ctx, buf);
-               memcpy(uuid, buf, sizeof(uuid));
-       }
+       if (vcl)
+               guid = vcl->conf.guid;
+       else
+               guid = ddf->anchor.guid;
+
+       sha1_init_ctx(&ctx);
+       sha1_process_bytes(guid, DDF_GUID_LEN, &ctx);
+       if (vcl && vcl->conf.sec_elmnt_count > 1)
+               sha1_process_bytes(&vcl->conf.sec_elmnt_seq, 1, &ctx);
+       sha1_finish_ctx(&ctx, buf);
+       memcpy(uuid, buf, 4*4);
 }
 
 static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info);
@@ -1244,12 +1256,15 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info)
 
 
        info->reshape_active = 0;
+       info->name[0] = 0;
 
+       info->array.major_version = -1;
+       info->array.minor_version = -2;
        strcpy(info->text_version, "ddf");
+       info->safe_mode_delay = 0;
 
-//     uuid_from_super_ddf(info->uuid, sbv);
+       uuid_from_super_ddf(st, info->uuid);
 
-//     info->name[] ?? ;
 }
 
 static int rlq_to_layout(int rlq, int prl, int raiddisks);
@@ -1286,6 +1301,8 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info)
 //     info->disk.raid_disk = find refnum in the table and use index;
 //     info->disk.state = ???;
 
+       info->container_member = ddf->currentconf->vcnum;
+
        info->resync_start = 0;
        if (!(ddf->virt->entries[info->container_member].state
              & DDF_state_inconsistent)  &&
@@ -1297,11 +1314,14 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info)
        uuid_from_super_ddf(st, info->uuid);
 
        info->container_member = atoi(st->subarray);
+       info->array.major_version = -1;
+       info->array.minor_version = -2;
        sprintf(info->text_version, "/%s/%s",
                devnum2devname(st->container_dev),
                st->subarray);
+       info->safe_mode_delay = 200;
 
-//     info->name[] ?? ;
+       info->name[0] = 0;
 }
 
 
@@ -1710,6 +1730,7 @@ static int rlq_to_layout(int rlq, int prl, int raiddisks)
        return -1;
 }
 
+#ifndef MDASSEMBLE
 struct extent {
        unsigned long long start, size;
 };
@@ -1760,6 +1781,7 @@ FIXME ignore DDF_Legacy devices?
        rv[n].size = 0;
        return rv;
 }
+#endif
 
 static int init_super_ddf_bvd(struct supertype *st,
                              mdu_array_info_t *info,
@@ -1872,6 +1894,7 @@ static int init_super_ddf_bvd(struct supertype *st,
        return 1;
 }
 
+#ifndef MDASSEMBLE
 static void add_to_super_ddf_bvd(struct supertype *st,
                                 mdu_disk_info_t *dk, int fd, char *devname)
 {
@@ -1992,7 +2015,6 @@ static void add_to_super_ddf(struct supertype *st,
        dd->major = major(stb.st_rdev);
        dd->minor = minor(stb.st_rdev);
        dd->devname = devname;
-       dd->next = ddf->dlist;
        dd->fd = fd;
        dd->spare = NULL;
 
@@ -2025,8 +2047,20 @@ static void add_to_super_ddf(struct supertype *st,
        pde = &ddf->phys->entries[n];
        dd->pdnum = n;
 
-       n++;
-       ddf->phys->used_pdes = __cpu_to_be16(n);
+       if (st->update_tail) {
+               int len = (sizeof(struct phys_disk) +
+                          sizeof(struct phys_disk_entry));
+               struct phys_disk *pd;
+
+               pd = malloc(len);
+               pd->magic = DDF_PHYS_RECORDS_MAGIC;
+               pd->used_pdes = __cpu_to_be16(n);
+               pde = &pd->entries[0];
+               dd->mdupdate = pd;
+       } else {
+               n++;
+               ddf->phys->used_pdes = __cpu_to_be16(n);
+       }
 
        memcpy(pde->guid, dd->disk.guid, DDF_GUID_LEN);
        pde->refnum = dd->disk.refnum;
@@ -2039,8 +2073,14 @@ static void add_to_super_ddf(struct supertype *st,
        memset(pde->pad, 0xff, 6);
 
        dd->size = size >> 9;
-       ddf->dlist = dd;
-       ddf->updates_pending = 1;
+       if (st->update_tail) {
+               dd->next = ddf->add_list;
+               ddf->add_list = dd;
+       } else {
+               dd->next = ddf->dlist;
+               ddf->dlist = dd;
+               ddf->updates_pending = 1;
+       }
 }
 
 /*
@@ -2049,8 +2089,6 @@ static void add_to_super_ddf(struct supertype *st,
  * container.
  */
 
-#ifndef MDASSEMBLE
-
 static unsigned char null_conf[4096+512];
 
 static int __write_init_super_ddf(struct supertype *st, int do_close)
@@ -2159,6 +2197,21 @@ static int write_init_super_ddf(struct supertype *st)
                struct ddf_super *ddf = st->sb;
                int len;
 
+               if (!ddf->currentconf) {
+                       int len = (sizeof(struct phys_disk) +
+                                  sizeof(struct phys_disk_entry));
+
+                       /* adding a disk to the container. */
+                       if (!ddf->add_list)
+                               return 0;
+
+                       append_metadata_update(st, ddf->add_list->mdupdate, len);
+                       ddf->add_list->mdupdate = NULL;
+                       return 0;
+               }
+
+               /* Newly created VD */
+
                /* First the virtual disk.  We have a slightly fake header */
                len = sizeof(struct virtual_disk) + sizeof(struct virtual_entry);
                vd = malloc(len);
@@ -2190,20 +2243,24 @@ static __u64 avail_size_ddf(struct supertype *st, __u64 devsize)
 }
 
 #ifndef MDASSEMBLE
-static int validate_geometry_ddf_container(struct supertype *st,
-                                   int level, int layout, int raiddisks,
-                                   int chunk, unsigned long long size,
-                                   char *dev, unsigned long long *freesize);
+static int
+validate_geometry_ddf_container(struct supertype *st,
+                               int level, int layout, int raiddisks,
+                               int chunk, unsigned long long size,
+                               char *dev, unsigned long long *freesize,
+                               int verbose);
 
 static int validate_geometry_ddf_bvd(struct supertype *st,
                                     int level, int layout, int raiddisks,
                                     int chunk, unsigned long long size,
-                                    char *dev, unsigned long long *freesize);
+                                    char *dev, unsigned long long *freesize,
+                                    int verbose);
 
 static int validate_geometry_ddf(struct supertype *st,
-                         int level, int layout, int raiddisks,
-                         int chunk, unsigned long long size,
-                         char *dev, unsigned long long *freesize)
+                                int level, int layout, int raiddisks,
+                                int chunk, unsigned long long size,
+                                char *dev, unsigned long long *freesize,
+                                int verbose)
 {
        int fd;
        struct mdinfo *sra;
@@ -2219,8 +2276,9 @@ static int validate_geometry_ddf(struct supertype *st,
        if (level == LEVEL_CONTAINER) {
                /* Must be a fresh device to add to a container */
                return validate_geometry_ddf_container(st, level, layout,
-                                              raiddisks,
-                                              chunk, size, dev, freesize);
+                                                      raiddisks, chunk,
+                                                      size, dev, freesize,
+                                                      verbose);
        }
 
        if (st->sb) {
@@ -2229,7 +2287,8 @@ static int validate_geometry_ddf(struct supertype *st,
                 * Should make a distinction one day.
                 */
                return validate_geometry_ddf_bvd(st, level, layout, raiddisks,
-                                                chunk, size, dev, freesize);
+                                                chunk, size, dev, freesize,
+                                                verbose);
        }
        if (!dev) {
                /* Initial sanity check.  Exclude illegal levels. */
@@ -2263,22 +2322,26 @@ static int validate_geometry_ddf(struct supertype *st,
                        /* Somehow return the fact that we have enough */
                }
 
-               fprintf(stderr,
-                       Name ": Cannot create this array on device %s\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr,
+                               Name ": ddf: Cannot create this array "
+                               "on device %s\n",
+                               dev);
                return 0;
        }
        if (errno != EBUSY || (fd = open(dev, O_RDONLY, 0)) < 0) {
-               fprintf(stderr, Name ": Cannot open %s: %s\n",
-                       dev, strerror(errno));
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot open %s: %s\n",
+                               dev, strerror(errno));
                return 0;
        }
        /* Well, it is in use by someone, maybe a 'ddf' container. */
        cfd = open_container(fd);
        if (cfd < 0) {
                close(fd);
-               fprintf(stderr, Name ": Cannot use %s: It is busy\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot use %s: %s\n",
+                               dev, strerror(EBUSY));
                return 0;
        }
        sra = sysfs_read(cfd, 0, GET_VERSION);
@@ -2295,7 +2358,8 @@ static int validate_geometry_ddf(struct supertype *st,
                        close(cfd);
                        return validate_geometry_ddf_bvd(st, level, layout,
                                                         raiddisks, chunk, size,
-                                                        dev, freesize);
+                                                        dev, freesize,
+                                                        verbose);
                }
                close(cfd);
        } else /* device may belong to a different container */
@@ -2304,10 +2368,12 @@ static int validate_geometry_ddf(struct supertype *st,
        return 1;
 }
 
-static int validate_geometry_ddf_container(struct supertype *st,
-                                  int level, int layout, int raiddisks,
-                                  int chunk, unsigned long long size,
-                                  char *dev, unsigned long long *freesize)
+static int
+validate_geometry_ddf_container(struct supertype *st,
+                               int level, int layout, int raiddisks,
+                               int chunk, unsigned long long size,
+                               char *dev, unsigned long long *freesize,
+                               int verbose)
 {
        int fd;
        unsigned long long ldsize;
@@ -2319,8 +2385,9 @@ static int validate_geometry_ddf_container(struct supertype *st,
 
        fd = open(dev, O_RDONLY|O_EXCL, 0);
        if (fd < 0) {
-               fprintf(stderr, Name ": Cannot open %s: %s\n",
-                       dev, strerror(errno));
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot open %s: %s\n",
+                               dev, strerror(errno));
                return 0;
        }
        if (!get_dev_size(fd, dev, &ldsize)) {
@@ -2337,7 +2404,8 @@ static int validate_geometry_ddf_container(struct supertype *st,
 static int validate_geometry_ddf_bvd(struct supertype *st,
                                     int level, int layout, int raiddisks,
                                     int chunk, unsigned long long size,
-                                    char *dev, unsigned long long *freesize)
+                                    char *dev, unsigned long long *freesize,
+                                    int verbose)
 {
        struct stat stb;
        struct ddf_super *ddf = st->sb;
@@ -2382,9 +2450,11 @@ static int validate_geometry_ddf_bvd(struct supertype *st,
                        free(e);
                }
                if (dcnt < raiddisks) {
-                       fprintf(stderr, Name ": Not enough devices with space "
-                               "for this array (%d < %d)\n",
-                               dcnt, raiddisks);
+                       if (verbose)
+                               fprintf(stderr,
+                                       Name ": ddf: Not enough devices with "
+                                       "space for this array (%d < %d)\n",
+                                       dcnt, raiddisks);
                        return 0;
                }
                return 1;
@@ -2400,8 +2470,10 @@ static int validate_geometry_ddf_bvd(struct supertype *st,
                        break;
        }
        if (!dl) {
-               fprintf(stderr, Name ": %s is not in the same DDF set\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: %s is not in the "
+                               "same DDF set\n",
+                               dev);
                return 0;
        }
        e = get_extents(ddf, dl);
@@ -2479,6 +2551,7 @@ static int load_super_ddf_all(struct supertype *st, int fd,
                dfd = dev_open(nm, keep_fd? O_RDWR : O_RDONLY);
                if (dfd < 0)
                        return 2;
+               load_ddf_headers(dfd, super, NULL);
                seq = load_ddf_local(dfd, super, NULL, keep_fd);
                if (!keep_fd) close(dfd);
        }
@@ -2498,9 +2571,10 @@ static int load_super_ddf_all(struct supertype *st, int fd,
                st->max_devs = 512;
                st->container_dev = fd2devnum(fd);
        }
+       st->loaded_container = 1;
        return 0;
 }
-#endif
+#endif /* MDASSEMBLE */
 
 static struct mdinfo *container_content_ddf(struct supertype *st)
 {
@@ -2531,6 +2605,8 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                this->array.layout = rlq_to_layout(vc->conf.rlq, vc->conf.prl,
                                                   this->array.raid_disks);
                this->array.md_minor      = -1;
+               this->array.major_version = -1;
+               this->array.minor_version = -2;
                this->array.ctime         = DECADE +
                        __be32_to_cpu(*(__u32*)(vc->conf.guid+16));
                this->array.utime         = DECADE +
@@ -2548,13 +2624,17 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                        this->resync_start = ~0ULL;
                }
                memcpy(this->name, ddf->virt->entries[i].name, 32);
-               this->name[33]=0;
+               this->name[32]=0;
 
                memset(this->uuid, 0, sizeof(this->uuid));
                this->component_size = __be64_to_cpu(vc->conf.blocks);
                this->array.size = this->component_size / 2;
                this->container_member = i;
 
+               ddf->currentconf = vc;
+               uuid_from_super_ddf(st, this->uuid);
+               ddf->currentconf = NULL;
+
                sprintf(this->text_version, "/%s/%d",
                        devnum2devname(st->container_dev),
                        this->container_member);
@@ -2585,8 +2665,8 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                        dev->disk.raid_disk = i;
                        dev->disk.state = (1<<MD_DISK_SYNC)|(1<<MD_DISK_ACTIVE);
 
-                       dev->events = __le32_to_cpu(ddf->primary.seq);
-                       dev->data_offset = vc->lba_offset[i];
+                       dev->events = __be32_to_cpu(ddf->primary.seq);
+                       dev->data_offset = __be64_to_cpu(vc->lba_offset[i]);
                        dev->component_size = __be64_to_cpu(vc->conf.blocks);
                        if (d->devname)
                                strcpy(dev->name, d->devname);
@@ -2637,6 +2717,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
        return 0;
 }
 
+#ifndef MDASSEMBLE
 /*
  * A new array 'a' has been started which claims to be instance 'inst'
  * within container 'c'.
@@ -2645,7 +2726,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
  */
 static int ddf_open_new(struct supertype *c, struct active_array *a, char *inst)
 {
-       fprintf(stderr, "ddf: open_new %s\n", inst);
+       dprintf("ddf: open_new %s\n", inst);
        a->info.container_member = atoi(inst);
        return 0;
 }
@@ -2659,11 +2740,17 @@ static int ddf_open_new(struct supertype *c, struct active_array *a, char *inst)
  * For DDF, we need to clear the DDF_state_inconsistent bit in the
  * !global! virtual_disk.virtual_entry structure.
  */
-static void ddf_set_array_state(struct active_array *a, int consistent)
+static int ddf_set_array_state(struct active_array *a, int consistent)
 {
        struct ddf_super *ddf = a->container->sb;
        int inst = a->info.container_member;
        int old = ddf->virt->entries[inst].state;
+       if (consistent == 2) {
+               /* Should check if a recovery should be started FIXME */
+               consistent = 1;
+               if (a->resync_start != ~0ULL)
+                       consistent = 0;
+       }
        if (consistent)
                ddf->virt->entries[inst].state &= ~DDF_state_inconsistent;
        else
@@ -2682,8 +2769,9 @@ static void ddf_set_array_state(struct active_array *a, int consistent)
        if (old != ddf->virt->entries[inst].init_state)
                ddf->updates_pending = 1;
 
-       printf("ddf mark %d %s %llu\n", inst, consistent?"clean":"dirty",
-              a->resync_start);
+       dprintf("ddf mark %d %s %llu\n", inst, consistent?"clean":"dirty",
+               a->resync_start);
+       return consistent;
 }
 
 /*
@@ -2709,7 +2797,7 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
        int i, st, working;
 
        if (vc == NULL) {
-               fprintf(stderr, "ddf: cannot find instance %d!!\n", inst);
+               dprintf("ddf: cannot find instance %d!!\n", inst);
                return;
        }
        if (pd < 0) {
@@ -2734,7 +2822,7 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
                        ddf->updates_pending = 1;
        }
 
-       fprintf(stderr, "ddf: set_disk %d to %x\n", n, state);
+       dprintf("ddf: set_disk %d to %x\n", n, state);
 
        /* Now we need to check the state of the array and update
         * virtual_disk.entries[n].state.
@@ -2804,7 +2892,7 @@ static void ddf_sync_metadata(struct supertype *st)
                return;
        ddf->updates_pending = 0;
        __write_init_super_ddf(st, 0);
-       fprintf(stderr, "ddf: sync_metadata\n");
+       dprintf("ddf: sync_metadata\n");
 }
 
 static void ddf_process_update(struct supertype *st,
@@ -2847,7 +2935,7 @@ static void ddf_process_update(struct supertype *st,
        int mppe;
        int ent;
 
-//     printf("Process update %x\n", *magic);
+       dprintf("Process update %x\n", *magic);
 
        switch (*magic) {
        case DDF_PHYS_RECORDS_MAGIC:
@@ -2866,6 +2954,20 @@ static void ddf_process_update(struct supertype *st,
                ddf->phys->used_pdes = __cpu_to_be16(1 +
                                           __be16_to_cpu(ddf->phys->used_pdes));
                ddf->updates_pending = 1;
+               if (ddf->add_list) {
+                       struct active_array *a;
+                       struct dl *al = ddf->add_list;
+                       ddf->add_list = al->next;
+
+                       al->next = ddf->dlist;
+                       ddf->dlist = al;
+
+                       /* As a device has been added, we should check
+                        * for any degraded devices that might make
+                        * use of this spare */
+                       for (a = st->arrays ; a; a=a->next)
+                               a->check_degraded = 1;
+               }
                break;
 
        case DDF_VIRT_RECORDS_MAGIC:
@@ -2887,7 +2989,7 @@ static void ddf_process_update(struct supertype *st,
                break;
 
        case DDF_VD_CONF_MAGIC:
-//             printf("len %d %d\n", update->len, ddf->conf_rec_len);
+               dprintf("len %d %d\n", update->len, ddf->conf_rec_len);
 
                mppe = __be16_to_cpu(ddf->anchor.max_primary_element_entries);
                if (update->len != ddf->conf_rec_len * 512)
@@ -2896,7 +2998,7 @@ static void ddf_process_update(struct supertype *st,
                for (vcl = ddf->conflist; vcl ; vcl = vcl->next)
                        if (memcmp(vcl->conf.guid, vc->guid, DDF_GUID_LEN) == 0)
                                break;
-//             printf("vcl = %p\n", vcl);
+               dprintf("vcl = %p\n", vcl);
                if (vcl) {
                        /* An update, just copy the phys_refnum and lba_offset
                         * fields
@@ -2921,8 +3023,8 @@ static void ddf_process_update(struct supertype *st,
                                for (dn=0; dn < ddf->mppe ; dn++)
                                        if (vcl->conf.phys_refnum[dn] ==
                                            dl->disk.refnum) {
-//                                             printf("dev %d has %p at %d\n",
-//                                                    dl->pdnum, vcl, vn);
+                                               dprintf("dev %d has %p at %d\n",
+                                                       dl->pdnum, vcl, vn);
                                                dl->vlist[vn++] = vcl;
                                                break;
                                        }
@@ -3009,8 +3111,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        working ++;
        }
 
-//     printf("ddf_activate: working=%d (%d) level=%d\n", working, a->info.array.raid_disks,
-//            a->info.array.level);
+       dprintf("ddf_activate: working=%d (%d) level=%d\n", working, a->info.array.raid_disks,
+               a->info.array.level);
        if (working == a->info.array.raid_disks)
                return NULL; /* array not degraded */
        switch (a->info.array.level) {
@@ -3037,7 +3139,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                for (d = a->info.devs ; d ; d = d->next)
                        if (d->disk.raid_disk == i)
                                break;
-               printf("found %d: %p %x\n", i, d, d?d->curr_state:0);
+               dprintf("found %d: %p %x\n", i, d, d?d->curr_state:0);
                if (d && (d->state_fd >= 0))
                        continue;
 
@@ -3055,7 +3157,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        for (d2 = a->info.devs ; d2 ; d2 = d2->next)
                                if (d2->disk.major == dl->major &&
                                    d2->disk.minor == dl->minor) {
-                                       printf("%x:%x already in array\n", dl->major, dl->minor);
+                                       dprintf("%x:%x already in array\n", dl->major, dl->minor);
                                        break;
                                }
                        if (d2)
@@ -3083,7 +3185,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        }
                        if ( ! (is_dedicated ||
                                (is_global && global_ok))) {
-                               printf("%x:%x not suitable: %d %d\n", dl->major, dl->minor,
+                               dprintf("%x:%x not suitable: %d %d\n", dl->major, dl->minor,
                                       is_dedicated, is_global);
                                continue;
                        }
@@ -3092,7 +3194,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                         * We need a->info.component_size sectors */
                        ex = get_extents(ddf, dl);
                        if (!ex) {
-                               printf("cannot get extents\n");
+                               dprintf("cannot get extents\n");
                                continue;
                        }
                        j = 0; pos = 0;
@@ -3108,8 +3210,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
 
                        free(ex);
                        if (esize < a->info.component_size) {
-                               printf("%x:%x has no room: %llu %llu\n", dl->major, dl->minor,
-                                      esize, a->info.component_size);
+                               dprintf("%x:%x has no room: %llu %llu\n", dl->major, dl->minor,
+                                       esize, a->info.component_size);
                                /* No room */
                                continue;
                        }
@@ -3127,8 +3229,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        di->container_member = dl->pdnum;
                        di->next = rv;
                        rv = di;
-                       printf("%x:%x to be %d at %llu\n", dl->major, dl->minor,
-                              i, pos);
+                       dprintf("%x:%x to be %d at %llu\n", dl->major, dl->minor,
+                               i, pos);
 
                        break;
                }
@@ -3165,6 +3267,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
        *updates = mu;
        return rv;
 }
+#endif /* MDASSEMBLE */
 
 struct superswitch super_ddf = {
 #ifndef        MDASSEMBLE
@@ -3174,6 +3277,7 @@ struct superswitch super_ddf = {
        .brief_detail_super = brief_detail_super_ddf,
        .validate_geometry = validate_geometry_ddf,
        .write_init_super = write_init_super_ddf,
+       .add_to_super   = add_to_super_ddf,
 #endif
        .match_home     = match_home_ddf,
        .uuid_from_super= uuid_from_super_ddf,
@@ -3189,11 +3293,11 @@ struct superswitch super_ddf = {
        .store_super    = store_zero_ddf,
        .free_super     = free_super_ddf,
        .match_metadata_desc = match_metadata_desc_ddf,
-       .add_to_super   = add_to_super_ddf,
        .container_content = container_content_ddf,
 
        .external       = 1,
 
+#ifndef MDASSEMBLE
 /* for mdmon */
        .open_new       = ddf_open_new,
        .set_array_state= ddf_set_array_state,
@@ -3202,5 +3306,5 @@ struct superswitch super_ddf = {
        .process_update = ddf_process_update,
        .prepare_update = ddf_prepare_update,
        .activate_spare = ddf_activate_spare,
-
+#endif
 };