]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Monitor: check spare group is non-NULL before adding to domain list
authorNeilBrown <neilb@suse.de>
Tue, 23 Nov 2010 00:11:45 +0000 (11:11 +1100)
committerNeilBrown <neilb@suse.de>
Tue, 23 Nov 2010 00:11:45 +0000 (11:11 +1100)
... otherwise we crash.

Reported-by: "Labun, Marcin" <Marcin.Labun@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Monitor.c

index b907cf2d9142745da5a19c1a6fb95a072f05b266..e0c86917b5276e125d1723d4b77487469028d48e 100644 (file)
--- a/Monitor.c
+++ b/Monitor.c
@@ -732,7 +732,9 @@ static int move_spare(struct state *from, struct state *to,
                                continue;
 
                        pol = devnum_policy(from->devid[d]);
-                       pol_add(&pol, pol_domain, from->spare_group, NULL);
+                       if (from->spare_group)
+                               pol_add(&pol, pol_domain,
+                                       from->spare_group, NULL);
                        if (domain_test(domlist, pol, to->metadata->ss->name))
                            dev = from->devid[d];
                        dev_policy_free(pol);