Create: don't default to bitmap=internal when it is not supported

For large arrays (component size > 100GB) if write-intent bitmap is not
enabled, then it is set by default to "internal", even if the metadata
format does support internal bitmaps, which causes Create to fail.

This patch adds checking if add_internal_bitmap is set in the
superswitch before setting bitmap_file to "internal".

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/Create.c b/Create.c
index 98bbdd40a1612ec704674aae1a2ad2fac7f049fb..1ab43640988016ac066947e59ce05eb7c9afe9ae 100644 (file)
--- a/Create.c
+++ b/Create.c
@@ -509,6 +509,7 @@ int Create(struct supertype *st, char *mddev,
 
        if (!s->bitmap_file &&
            s->level >= 1 &&
+           st->ss->add_internal_bitmap &&
            (s->write_behind || s->size > 100*1024*1024ULL)) {
                if (c->verbose > 0)
                        pr_err("automatically enabling write-intent bitmap on large array\n");