Assemble: cleanup the failure path

There are some failure paths which share common codes
before return, so simplify them by move common codes
to the end of function, and just goto out in case
failure happened.

Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>

diff --git a/Assemble.c b/Assemble.c
index 32eb978ff56de4b958726bff66785d3345dde1b7..e83d550b2c7bd80c6f4b9726e17ba16307c7882a 100644 (file)
--- a/Assemble.c
+++ b/Assemble.c
@@ -1313,13 +1313,13 @@ int Assemble(struct supertype *st, char *mddev,
         *    START_ARRAY
         *
         */
-       int rv;
-       int mdfd;
+       int rv = -1;
+       int mdfd = -1;
        int clean;
        int auto_assem = (mddev == NULL && !ident->uuid_set &&
                          ident->super_minor == UnSet && ident->name[0] == 0 &&
                          (ident->container == NULL || ident->member == NULL));
-       struct devs *devices;
+       struct devs *devices = NULL;
        char *devmap;
        int *best = NULL; /* indexed by raid_disk */
        int bestcnt = 0;
@@ -1434,9 +1434,7 @@ try_again:
                        pr_err("Found some drive for an array that is already active: %s\n",
                               mp->path);
                        pr_err("giving up.\n");
-                       if (locked == 1)
-                               cluster_release_dlmlock();
-                       return 1;
+                       goto out;
                }
                for (dv = pre_exist->devs; dv; dv = dv->next) {
                        /* We want to add this device to our list,
@@ -1509,9 +1507,7 @@ try_again:
                st->ss->free_super(st);
                if (auto_assem)
                        goto try_again;
-               if (locked == 1)
-                       cluster_release_dlmlock();
-               return 1;
+               goto out;
        }
        mddev = chosen_name;
        if (pre_exist == NULL) {
@@ -1530,9 +1526,7 @@ try_again:
                        st->ss->free_super(st);
                        if (auto_assem)
                                goto try_again;
-                       if (locked == 1)
-                               cluster_release_dlmlock();
-                       return 1;
+                       goto out;
                }
                /* just incase it was started but has no content */
                ioctl(mdfd, STOP_ARRAY, NULL);
@@ -1556,9 +1550,8 @@ try_again:
                              c, content, mdfd, mddev,
                              &most_recent, &bestcnt, &best, inargv);
        if (devcnt < 0) {
-               if (locked == 1)
-                       cluster_release_dlmlock();
-               return 1;
+               mdfd = -3;
+               goto out;
        }
 
        if (devcnt == 0) {
@@ -1566,10 +1559,8 @@ try_again:
                       mddev);
                if (st)
                        st->ss->free_super(st);
-               close(mdfd);
-               free(devices);
                free(devmap);
-               return 1;
+               goto out;
        }
 
        if (c->update && strcmp(c->update, "byteorder")==0)
@@ -1683,32 +1674,24 @@ try_again:
                                 : (O_RDONLY|O_EXCL)))< 0) {
                        pr_err("Cannot open %s: %s\n",
                               devices[j].devname, strerror(errno));
-                       close(mdfd);
-                       free(devices);
-                       return 1;
+                       goto out;
                }
                if (st->ss->load_super(st,fd, NULL)) {
                        close(fd);
                        pr_err("RAID superblock has disappeared from %s\n",
                               devices[j].devname);
-                       close(mdfd);
-                       free(devices);
-                       return 1;
+                       goto out;
                }
                close(fd);
        }
        if (st->sb == NULL) {
                pr_err("No suitable drives found for %s\n", mddev);
-               close(mdfd);
-               free(devices);
-               return 1;
+               goto out;
        }
        st->ss->getinfo_super(st, content, NULL);
        if (sysfs_init(content, mdfd, NULL)) {
                pr_err("Unable to initialize sysfs\n");
-               close(mdfd);
-               free(devices);
-               return 1;
+               goto out;
        }
 
        /* after reload context, store journal_clean in context */
@@ -1774,17 +1757,13 @@ try_again:
                if (fd < 0) {
                        pr_err("Could not open %s for write - cannot Assemble array.\n",
                               devices[chosen_drive].devname);
-                       close(mdfd);
-                       free(devices);
-                       return 1;
+                       goto out;
                }
                if (st->ss->store_super(st, fd)) {
                        close(fd);
                        pr_err("Could not re-write superblock on %s\n",
                               devices[chosen_drive].devname);
-                       close(mdfd);
-                       free(devices);
-                       return 1;
+                       goto out;
                }
                if (c->verbose >= 0)
                        pr_err("Marking array %s as 'clean'\n",
@@ -1842,9 +1821,7 @@ try_again:
                        pr_err("Failed to restore critical section for reshape, sorry.\n");
                        if (c->backup_file == NULL)
                                cont_err("Possibly you needed to specify the --backup-file\n");
-                       close(mdfd);
-                       free(devices);
-                       return err;
+                       goto out;
                }
        }
 
@@ -1873,6 +1850,7 @@ try_again:
                ioctl(mdfd, STOP_ARRAY, NULL);
        free(devices);
        map_unlock(&map);
+out:
        if (rv == 0) {
                wait_for(chosen_name, mdfd);
                close(mdfd);
@@ -1902,12 +1880,16 @@ try_again:
                                usecs <<= 1;
                        }
                }
-       } else
+       } else if (mdfd >= 0)
                close(mdfd);
 
        /* '2' means 'OK, but not started yet' */
        if (locked == 1)
                cluster_release_dlmlock();
+       if (rv == -1) {
+               free(devices);
+               return 1;
+       }
        return rv == 2 ? 0 : rv;
 }