]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
mdadm/grow: reshape would be stuck from raid1 to raid5
authorZhilong Liu <zlliu@suse.com>
Thu, 30 Mar 2017 07:38:08 +0000 (15:38 +0800)
committerJes Sorensen <Jes.Sorensen@gmail.com>
Thu, 30 Mar 2017 15:49:44 +0000 (11:49 -0400)
systemctl doesn't interpret mdadm-grow-continue@.service
correctly due to the wrong argument provided in [service],
it should be corrected %I as %i. Otherwise, if the service
cannot start by systemctl and the reshap progress would be
stuck all time when grows array from raid1 to raid5.

reproduce steps:
./mdadm -CR /dev/md0 -l1 -b internal -n2 /dev/loop[0-1]
./mdadm --grow /dev/md0 -l5 -n3 -a /dev/loop2

Signed-off-by: Zhilong Liu <zlliu@suse.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@gmail.com>
systemd/mdadm-grow-continue@.service

index 5c667d2a71f64bcfb8cac57cb43f7c7e15a91f0d..882bc0b049b283bff6846bc6f736c902427a98bb 100644 (file)
@@ -10,7 +10,7 @@ Description=Manage MD Reshape on /dev/%I
 DefaultDependencies=no
 
 [Service]
-ExecStart=BINDIR/mdadm --grow --continue /dev/%I
+ExecStart=BINDIR/mdadm --grow --continue /dev/%i
 StandardInput=null
 StandardOutput=null
 StandardError=null