]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
test: assume recovery has completed if sync_completed says so.
authorNeilBrown <neilb@suse.com>
Thu, 23 Jul 2015 01:17:10 +0000 (11:17 +1000)
committerNeilBrown <neilb@suse.com>
Thu, 23 Jul 2015 01:17:10 +0000 (11:17 +1000)
The final completion of a recovery can be delayed, so use
sync_completed to check if it is finished, just not been reaped.

Signed-off-by: NeilBrown <neilb@suse.com>
test

diff --git a/test b/test
index 939410ce85e29a12612003d021d23f6b5fcefce1..d0a6cb8582129b4ff2b8266e088f94f26f90b1cd 100755 (executable)
--- a/test
+++ b/test
@@ -205,8 +205,16 @@ check() {
 
      nosync )
        sleep 0.5
+       # Since 4.2 we delay the close of recovery until there has been a chance for
+       # spares to be activated.  That means that a recovery that finds nothing
+       # to do can still take a little longer than expected.
+       # add an extra check: is sync_completed shows the end is reached, assume
+       # there is no recovery.
        if grep -s -E '(resync|recovery|reshape) *=' > /dev/null /proc/mdstat ; then
+          incomplete=`grep / /sys/block/md*/md/sync_completed 2> /dev/null | sed '/^ *\([0-9]*\) \/ \1/d'`
+          if [ -n "$incomplete" ]; then
                echo >&2 "ERROR resync or recovery is happening!"; cat /proc/mdstat ; exit 1;
+          fi
        fi
      ;;