]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
DDF: remove an old incorrect FIXME comment.
authorNeilBrown <neilb@suse.de>
Wed, 21 May 2014 03:00:08 +0000 (13:00 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 21 May 2014 03:00:08 +0000 (13:00 +1000)
We mustn't close fds in write_init_super if ->update_tail
was set.

Signed-off-by: NeilBrown <neilb@suse.de>
super-ddf.c

index 943b51aa0aaffa083bb2a78d671cf5ec9647b35e..d3234c5bc0cf030e3f5d10e3ad02856c4d196164 100644 (file)
@@ -3259,13 +3259,15 @@ static int write_init_super_ddf(struct supertype *st)
                               len);
                append_metadata_update(st, vc, tlen);
 
-               /* FIXME I need to close the fds! */
                return 0;
        } else {
                struct dl *d;
                if (!currentconf)
                        for (d = ddf->dlist; d; d=d->next)
                                while (Kill(d->devname, NULL, 0, -1, 1) == 0);
+               /* Note: we don't close the fd's now, but a subsequent
+                * ->free_super() will
+                */
                return __write_init_super_ddf(st);
        }
 }