]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Include count for \0 character when using strncpy to implement strdup.
authorJes Sorensen <jsorensen@fb.com>
Tue, 19 May 2020 00:19:53 +0000 (20:19 -0400)
committerJes Sorensen <jsorensen@fb.com>
Tue, 19 May 2020 00:19:53 +0000 (20:19 -0400)
We have to include the \0 character in the length when copying a
string with strncpy() for which length was found with strlen().
Otherwise the destination will not get null terminated - except that
we explicitly zeroed it out earlier.

This quiets down the compiler's warnings.

Signed-off-by: Jes Sorensen <jsorensen@fb.com>
dlink.c

diff --git a/dlink.c b/dlink.c
index 3efa94b751ab233ee50ae7d03228490065fe6b7d..69aa7aa3930f348ad352050011287d10f700bce2 100644 (file)
--- a/dlink.c
+++ b/dlink.c
@@ -63,7 +63,7 @@ char *dl_strndup(char *s, int l)
     if (s == NULL)
        return NULL;
     n = dl_newv(char, l+1);
-    strncpy(n, s, l);
+    strncpy(n, s, l+1);
     n[l] = 0;
     return n;
 }