]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Create: check the node nums when create clustered raid
authorGuoqing Jiang <gqjiang@suse.com>
Wed, 4 May 2016 08:33:43 +0000 (16:33 +0800)
committerJes Sorensen <Jes.Sorensen@redhat.com>
Mon, 9 May 2016 18:59:01 +0000 (14:59 -0400)
It doesn't make sense to create a clustered raid
with only 1 node.

Reported-by: Zhilong Liu <zlliu@suse.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Create.c

index 1e4a6ee065fde6a201bb1e356126cadf46ff711d..717086b080fef60f435b52a0ac15e0d31529256e 100644 (file)
--- a/Create.c
+++ b/Create.c
@@ -114,8 +114,13 @@ int Create(struct supertype *st, char *mddev,
        unsigned long long newsize;
 
        int major_num = BITMAP_MAJOR_HI;
-       if (s->bitmap_file && strcmp(s->bitmap_file, "clustered") == 0)
+       if (s->bitmap_file && strcmp(s->bitmap_file, "clustered") == 0) {
                major_num = BITMAP_MAJOR_CLUSTERED;
+               if (c->nodes <= 1) {
+                       pr_err("At least 2 nodes are needed for cluster-md\n");
+                       return 1;
+               }
+       }
 
        memset(&info, 0, sizeof(info));
        if (s->level == UnSet && st && st->ss->default_geometry)