]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Fix regression during add devices
authorHannes Reinecke <hare@suse.de>
Wed, 9 Mar 2016 05:20:18 +0000 (13:20 +0800)
committerJes Sorensen <Jes.Sorensen@redhat.com>
Thu, 10 Mar 2016 16:44:21 +0000 (11:44 -0500)
Commit d180d2aa2a17 ("Manage: fix test for 'is array failed'.")
introduced a regression which would not allow to re-add new
drivers to a failed array.

Fixes: d180d2aa2a17 ("Manage: fix test for 'is array failed'.")
Signed-off-by: Hannes Reinecke <hare@suse.de>
Cc: Coly Li <colyli@suse.de>
Cc: Neil Brown <neilb@suse.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Manage.c

index ab4ac09fbefc4c5dbd934cb094c7cefd04ce1d56..e3d46f3b968ec28bc2cfef44e026a624f5ca7084 100644 (file)
--- a/Manage.c
+++ b/Manage.c
@@ -880,10 +880,10 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
                                        continue;
                                if (disc.major == 0 && disc.minor == 0)
                                        continue;
-                               found++;
                                if (!(disc.state & (1<<MD_DISK_SYNC)))
                                        continue;
                                avail[disc.raid_disk] = 1;
+                               found++;
                        }
                        array_failed = !enough(array->level, array->raid_disks,
                                               array->layout, 1, avail);