]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Allow level migration only for single-array container
authorMariusz Dabrowski <mariusz.dabrowski@intel.com>
Wed, 12 Oct 2016 12:29:42 +0000 (14:29 +0200)
committerJes Sorensen <Jes.Sorensen@redhat.com>
Wed, 19 Oct 2016 15:26:49 +0000 (11:26 -0400)
IMSM doesn't allow to change RAID level of array in container with two
arrays but array count check is being done too late (after removing disks)
and in some cases (e. g. RAID 0 and RAID 1 migrated to RAID 0) both arrays
become degraded. This patch adds array count check before disks are being
removed.

Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Grow.c

diff --git a/Grow.c b/Grow.c
index 628f0e74d047880ab4fcdd35e8dc1a08c821e27b..a8f62432c86a4170f80931e5ca7ad34f680d2e7d 100755 (executable)
--- a/Grow.c
+++ b/Grow.c
@@ -777,6 +777,26 @@ int remove_disks_for_takeover(struct supertype *st,
        struct mdinfo *remaining;
        int slot;
 
+       if (st->ss->external) {
+               int rv = 0;
+               struct mdinfo *arrays = st->ss->container_content(st, NULL);
+               /*
+                * containter_content returns list of arrays in container
+                * If arrays->next is not NULL it means that there are
+                * 2 arrays in container and operation should be blocked
+                */
+               if (arrays) {
+                       if (arrays->next)
+                               rv = 1;
+                       sysfs_free(arrays);
+                       if (rv) {
+                               pr_err("Error. Cannot perform operation on /dev/%s\n", st->devnm);
+                               pr_err("For this operation it MUST be single array in container\n");
+                               return rv;
+                       }
+               }
+       }
+
        if (sra->array.level == 10)
                nr_of_copies = layout & 0xff;
        else if (sra->array.level == 1)