From: Gioh Kim Date: Thu, 30 Mar 2017 16:58:13 +0000 (+0200) Subject: mdadm.c: fix compile error "switch condition has boolean value" X-Git-Tag: mdadm-4.1-rc1~219 X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fmdadm.git;a=commitdiff_plain;h=13428e2e76e8149336282d514908ced424f878a2 mdadm.c: fix compile error "switch condition has boolean value" Remove a boolean expression in switch condition to prevent compile error of some compilers, for example, gcc version 5.2.1 20151010 (Ubuntu 5.2.1-22ubuntu2). Signed-off-by: Gioh Kim Signed-off-by: Jes Sorensen --- diff --git a/mdadm.c b/mdadm.c index 0f327738..d6b54378 100644 --- a/mdadm.c +++ b/mdadm.c @@ -1965,14 +1965,12 @@ static int misc_list(struct mddev_dev *devlist, rv |= SetAction(dv->devname, c->action); continue; } - switch(dv->devname[0] == '/') { - case 0: - mdfd = open_dev(dv->devname); - if (mdfd >= 0) - break; - case 1: - mdfd = open_mddev(dv->devname, 1); - } + + if (dv->devname[0] != '/') + mdfd = open_dev(dv->devname); + if (dv->devname[0] == '/' || mdfd < 0) + mdfd = open_mddev(dv->devname, 1); + if (mdfd >= 0) { switch(dv->disposition) { case 'R':