From: NeilBrown <neilb@suse.de>
Date: Fri, 18 Jul 2008 06:37:18 +0000 (+1000)
Subject: sysfs: avoid possible data corruption in sys_load.
X-Git-Tag: mdadm-3.0-devel1~99
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fmdadm.git;a=commitdiff_plain;h=8dfb8619f928d58ac7369c42e9f94dd0dabfed4b

sysfs: avoid possible data corruption in sys_load.

Don't retry to remove a newline from the end of an empty string.

Signed-off-by: Neil Brown <neilb@suse.de>
---

diff --git a/sysfs.c b/sysfs.c
index bc021cc7..8979ec4e 100644
--- a/sysfs.c
+++ b/sysfs.c
@@ -37,7 +37,7 @@ int load_sys(char *path, char *buf)
 	if (n <0 || n >= 1024)
 		return -1;
 	buf[n] = 0;
-	if (buf[n-1] == '\n')
+	if (n && buf[n-1] == '\n')
 		buf[n-1] = 0;
 	return 0;
 }