From 3cb07116bbbc526715c05a2a8f9d2f5f4011e6f9 Mon Sep 17 00:00:00 2001 From: Neil Brown Date: Thu, 12 Jun 2008 10:13:19 +1000 Subject: [PATCH] Don't ignore errors in sysfs_add_disk. i.e. if the add fails, don't add the device to the internal data structures. --- sysfs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sysfs.c b/sysfs.c index dbfb55a8..344b1361 100644 --- a/sysfs.c +++ b/sysfs.c @@ -390,10 +390,11 @@ int sysfs_add_disk(struct mdinfo *sra, struct mdinfo *sd) rv |= sysfs_set_num(sra, sd, "slot", sd->disk.raid_disk); // rv |= sysfs_set_str(sra, sd, "state", "in_sync"); } - sd2 = malloc(sizeof(*sd2)); - *sd2 = *sd; - sd2->next = sra->devs; - sra->devs = sd2; - + if (! rv) { + sd2 = malloc(sizeof(*sd2)); + *sd2 = *sd; + sd2->next = sra->devs; + sra->devs = sd2; + } return rv; } -- 2.39.2